Merged
Conversation
Greptile SummaryFixed TypeScript type errors in test files that were causing build failures. Changes made:
Both changes align the test code with strict TypeScript type checking and modern JavaScript practices. Confidence Score: 5/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant Test as Test Suite
participant Mock as Mock Setup
participant Action as getAuthAction
participant Context as AuthKit Context
Note over Test,Context: actions.spec.ts - Function Call Fix
Test->>Mock: Setup mockAuthContext
Test->>Action: getAuthAction()
Note right of Action: No parameters (GET request)
Action->>Context: getRawAuthFromContext()
Context-->>Action: auth data
Action-->>Test: sanitized user info
Note over Test,Context: AuthKitProvider.spec.tsx - Window Mock Fix
Test->>Mock: Object.defineProperty(window, 'location', {...})
Note right of Mock: Proper TypeScript-safe mocking
Test->>Action: signOut({returnTo: '/home'})
Action-->>Mock: window.location.href = 'https://auth.workos.com/logout'
Test->>Mock: Object.defineProperty(window, 'location', {value: originalLocation})
Note right of Mock: Restore original location
|
dandorman
approved these changes
Dec 17, 2025
nholden
approved these changes
Dec 17, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are cuasing build errors