Skip to content

fix: improve URL validation in signOut redirect logic #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nicknisi merged 1 commit into from
Dec 10, 2025
Merged

fix: improve URL validation in signOut redirect logic #21

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 12 additions & 7 deletions src/client/AuthKitProvider.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,13 +81,18 @@ export function AuthKitProvider({ children, onSessionExpired }: AuthKitProviderP
if (error instanceof Response) {
const location = error.headers.get('Location');
if (location) {
// Check if external URL (WorkOS logout) or internal route
const isExternal = location.startsWith('http') && !location.includes(window.location.host);
if (isExternal) {
// External OAuth/logout URL requires full page navigation
window.location.href = location;
} else {
// Internal routes use TanStack Router navigation
try {
const url = new URL(location, window.location.origin);
if (url.origin === window.location.origin) {
// Internal routes use TanStack Router navigation with path only
const path = url.pathname + url.search + url.hash;
navigate({ to: path });
} else {
// External OAuth/logout URL requires full page navigation
window.location.href = location;
}
} catch {
// Invalid URL - use TanStack Router navigation as-is (for relative paths)
navigate({ to: location });
}
return;
Expand Down