Skip to content

Fix overlay not full screen in some devices (Issue 114) #148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jackyhieu1211-hn
Copy link

Fix overlay not full screen in some devices (Issue 114)
#114

@jackyhieu1211-hn jackyhieu1211-hn changed the title Fix overlay not full screen in some devices (Issue 114) Fix overlay not full screen in some devices (Issue https://github.com/worker8/TourGuide/issues/114) Sep 13, 2019
@jackyhieu1211-hn jackyhieu1211-hn changed the title Fix overlay not full screen in some devices (Issue https://github.com/worker8/TourGuide/issues/114) Fix overlay not full screen in some devices (Issue 114) Sep 13, 2019
@carlos-mg89
Copy link

carlos-mg89 commented Nov 1, 2021

@hieuseesaa thanks for the PR, it works fine!

@worker8 I've tested this pull request by changing the dependency import in my Gradle and it works like a charm:

implementation "com.github.hieuseesaa:tourguide:b00064a"

Could you please accept this PR and make another release? Alternatively, if you add me as maintainer of this library, I could do this for you as well. I could commit to this library.

Thanks in advance!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants