Skip to content

Fix initial scrollbar position of sidebar #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sonnyp merged 1 commit into from
Nov 11, 2023
Merged

Fix initial scrollbar position of sidebar #19

sonnyp merged 1 commit into from
Nov 11, 2023

Conversation

@AkshayWarrier
Copy link
Collaborator

@AkshayWarrier AkshayWarrier commented Nov 11, 2023

I can set this._adj.value to 0 after all the items are inserted as well but there's a delay so I'm doing it after every item is added.

@AkshayWarrier AkshayWarrier requested a review from sonnyp November 11, 2023 11:17
sonnyp
sonnyp approved these changes Nov 11, 2023
View reviewed changes
Copy link
Contributor

@sonnyp sonnyp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm wfm :)

@sonnyp sonnyp merged commit ceedeae into main Nov 11, 2023
@sonnyp sonnyp deleted the akshaywarrier/fix-scroll-pos branch November 11, 2023 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sonnyp sonnyp sonnyp approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@AkshayWarrier @sonnyp