Skip to content

Conversation

@colleran
Copy link

@colleran colleran commented May 8, 2020

No description provided.

delete("https://www.joinit.org/api/v1/organizations/me/webhooks?_id=#{webhook['_id']}")
},

dedup: ->(memberships) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Layout/AlignHash: Align the elements of a hash literal if they span more than one line.
Style/Lambda: Use the lambda method for multiline lambdas.

},

webhook_unsubscribe: ->(webhook) {
delete("https://www.joinit.org/api/v1/organizations/me/webhooks?_id=#{webhook['_id']}")
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Metrics/LineLength: Line is too long. [95/80]

event: "updated")
},

webhook_unsubscribe: ->(webhook) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Layout/AlignHash: Align the elements of a hash literal if they span more than one line.
Style/Lambda: Use the lambda method for multiline lambdas.

resource: "memberships",
event: "updated")
},

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Layout/TrailingWhitespace: Trailing whitespace detected.

object_id: webhook_url,
resource: "memberships",
event: "updated")
},
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Layout/BlockAlignment: } at 363, 6 is not aligned with ->(webhook_url, connection, input, recipe_id) { at 356, 26 or webhook_subscribe: ->(webhook_url, connection, input, recipe_id) { at 356, 7.

}
},

updated_memberships: {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Layout/AlignHash: Align the elements of a hash literal if they span more than one line.

object_definitions['memberships']
}
},

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Layout/TrailingWhitespace: Trailing whitespace detected.

payload
},

output_fields: ->(object_definitions) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Layout/AlignHash: Align the elements of a hash literal if they span more than one line.
Style/Lambda: Use the lambda method for multiline lambdas.

memberships['_id']
},

webhook_notification: ->(input, payload) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Layout/AlignHash: Align the elements of a hash literal if they span more than one line.
Style/Lambda: Use the lambda method for multiline lambdas.
Lint/UnusedBlockArgument: Unused block argument - input. If it's necessary, use _ or _input as an argument name to indicate that it won't be used.

dedup: ->(memberships) {
memberships['_id']
},

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Layout/TrailingWhitespace: Trailing whitespace detected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant