Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Gradle to 7.4 & AGP to 7.1.1 (& Disable Jetifier & Dependency Removal) #18

Closed
wants to merge 17 commits into from

Commits on Feb 15, 2022

  1. Configuration menu
    Copy the full SHA
    7961edc View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    602c830 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    eae00e7 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    dda5684 View commit details
    Browse the repository at this point in the history

Commits on Feb 23, 2022

  1. Configuration menu
    Copy the full SHA
    018921e View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    4a490a9 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    1546e6a View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    e6eef39 View commit details
    Browse the repository at this point in the history
  5. Build: Disable jetifier for android exoplayer project

    The 'com.dipien.byebyejetifier' plugin was used to determine whether
    Jetifier can be disable for this project.
    
    After configuring 'Bye Bye Jetifier' and running the below command:
    ./gradlew canISayByeByeJetifier -Pandroid.enableJetifier=false
    
    The output was clear, Jetifier can be now safely disabled for this
    project: > Task :canISayByeByeJetifier
    
    =========================================
    Project: :
    =========================================
    * No legacy android support usages found
    
    ===================================================== ...
    * No dependencies with legacy android support usages! ...
    ===================================================== ...
    
    ... ===============================
    ... You can say Bye Bye Jetifier. *
    ... ===============================
    ParaskP7 committed Feb 23, 2022
    Configuration menu
    Copy the full SHA
    9b0a575 View commit details
    Browse the repository at this point in the history
  6. Build: Disable jetifier for android project

    The 'com.dipien.byebyejetifier' plugin was used to determine whether
    Jetifier can be disable for this project.
    
    After configuring 'Bye Bye Jetifier' and running the below command:
    ./gradlew canISayByeByeJetifier -Pandroid.enableJetifier=false
    
    The output was clear, Jetifier can be now safely disabled for this
    project: > Task :canISayByeByeJetifier
    
    =========================================
    Project: :
    =========================================
    * No legacy android support usages found
    
    ===================================================== ...
    * No dependencies with legacy android support usages! ...
    ===================================================== ...
    
    ... ===============================
    ... You can say Bye Bye Jetifier. *
    ... ===============================
    ParaskP7 committed Feb 23, 2022
    Configuration menu
    Copy the full SHA
    12c932b View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    e8f82d0 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    669b5ec View commit details
    Browse the repository at this point in the history

Commits on Feb 24, 2022

  1. Build: Remove incorrect and as such unused okhttp dependency declaration

    Lint error message:
    "It looks like you are trying to substitute a version variable, but
     using single quotes ('). For Groovy string interpolation you must use
     double quotes (").
    
     To insert the value of a variable, you can use ${variable} inside a
     string literal, but only if you are using double quotes!"
    ParaskP7 committed Feb 24, 2022
    Configuration menu
    Copy the full SHA
    cb5181f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    bfb0880 View commit details
    Browse the repository at this point in the history

Commits on Feb 25, 2022

  1. Configuration menu
    Copy the full SHA
    9a599f2 View commit details
    Browse the repository at this point in the history

Commits on Feb 28, 2022

  1. Build: Add back incorrect and as such unused okhttp dep declaration

    For more info about that read full discussion here: https://github.com/
    /pull/18#discussion_r814883725
    ParaskP7 committed Feb 28, 2022
    Configuration menu
    Copy the full SHA
    4fa6833 View commit details
    Browse the repository at this point in the history

Commits on Mar 3, 2022

  1. Configuration menu
    Copy the full SHA
    b1bff8b View commit details
    Browse the repository at this point in the history