Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue/874 fix nested lists handling #973

Closed
wants to merge 16 commits into from
Closed

Issue/874 fix nested lists handling #973

wants to merge 16 commits into from

Conversation

SergioEstevao
Copy link
Contributor

@SergioEstevao SergioEstevao commented May 10, 2019 •
edited
Loading

Fixes: #874

Related GB PR: WordPress/gutenberg#15566
Relate Aztec PR: wordpress-mobile/AztecEditor-iOS#1181

This PR updates the list code to support the following:

  • Activates the indent/outdent buttons on the UI for the list block
  • Improves the handling of the Enter character and make sure the format of text between Aztec and the format library is consistent
  • Makes the handling of delete of new lines to be handled by the rich text format structure, instead of the native side.

How to test:

  • First of all try, the issue stated on List block split problem with nested lists #874 to see if it's working correctly
  • Then try to use the indent and outdent buttons and see if they work correctly
  • Try to delete list items and see if it works correctly

@SergioEstevao SergioEstevao added this to the v1.5 milestone May 10, 2019
@SergioEstevao SergioEstevao mentioned this pull request May 10, 2019
Merged
5 tasks
@etoledom
Copy link
Contributor

@SergioEstevao - Thanks for handling this!

I did a smoke test on the issue, and it seems to be resolved 🎉
There is one detail that I found:

  • Press enter on a nested list item to create a new empty item.
  • Try to delete the new list, it removes the indentation (that looks OK), but also creates a new list item with the same indentation as before, next to the current one (that does not look good).

Check the gif for a better visual explanation:

delete_list_item

@etoledom
Copy link
Contributor

The web side has a similar (but not completely the same) behavior, so it's probably an issue in the web side that is affecting us.

web_list_issue

@SergioEstevao
Copy link
Contributor Author

SergioEstevao commented May 13, 2019 via email

@SergioEstevao
Copy link
Contributor Author

@etoledom I just printed the HTML being produced by the JS side and the HTML we are producing in Aztec looks right. Not sure what to do.

@etoledom etoledom mentioned this pull request May 14, 2019
Merged
@SergioEstevao SergioEstevao modified the milestones: v1.5, v1.6 May 16, 2019
@SergioEstevao
Copy link
Contributor Author

Closing in favour of: #991

@SergioEstevao SergioEstevao deleted the issue/874_fix_nested_lists_handling branch May 16, 2019 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hypest hypest Awaiting requested review from hypest

@etoledom etoledom Awaiting requested review from etoledom

Assignees
No one assigned
Labels
[Status] Needs Android Dev [Type] Bug Something isn't working
Projects
None yet
Milestone
v1.6
Development

Successfully merging this pull request may close these issues.

List block split problem with nested lists
2 participants
@SergioEstevao @etoledom