Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement separator block #879

Merged
merged 3 commits into from
Apr 17, 2019
Merged

Implement separator block #879

merged 3 commits into from
Apr 17, 2019

Conversation

koke
Copy link
Member

@koke koke commented Apr 17, 2019

This PR just points Gutenberg to WordPress/gutenberg#14361, see that PR for details and discussion

Fixes #683

@koke koke added the Blocks label Apr 17, 2019
@koke koke added this to the v1.4 milestone Apr 17, 2019
@koke koke requested a review from pinarol April 17, 2019 10:01
pinarol
pinarol approved these changes Apr 17, 2019
View reviewed changes
Copy link
Contributor

@pinarol pinarol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎉
Tested with both iOS & Android example apps
Also tested on WPiOS and verified that separator block renders correctly on web preview and on classic editor

@koke koke merged commit c54dcb8 into develop Apr 17, 2019
@koke koke deleted the feature/separator-block branch April 17, 2019 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pinarol pinarol pinarol approved these changes

Assignees
No one assigned
Labels
Blocks
Projects
None yet
Milestone
v1.4
Development

Successfully merging this pull request may close these issues.

Separator Block
2 participants
@koke @pinarol