Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move Undo/Redo buttons #5889

Merged
merged 13 commits into from
Jul 11, 2023
Merged

Move Undo/Redo buttons #5889

merged 13 commits into from
Jul 11, 2023

Conversation

geriux
Copy link
Contributor

@geriux geriux commented Jun 21, 2023 •
edited
Loading

Related PRs:

To test CI checks should pass, verify the UI visual screenshots and make sure no other changes are made besides the new navigation headers for both iOS and Android.

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

This was referenced Jun 22, 2023
Merged
Merged
Merged
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Jun 29, 2023 •
edited
Loading

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

@geriux geriux added this to the 1.99.0 (22.8) milestone Jun 29, 2023
@geriux geriux force-pushed the move-undo-redo-buttons branch from 4d28e41 to e1dbccd Compare June 30, 2023 10:10
@geriux geriux requested a review from derekblank July 3, 2023 14:19
@geriux geriux marked this pull request as ready for review July 3, 2023 14:19
derekblank
derekblank approved these changes Jul 5, 2023
View reviewed changes
Copy link
Contributor

@derekblank derekblank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@fluiddot
Copy link
Contributor

fluiddot commented Jul 5, 2023

Hey @geriux 👋. We will cut the 1.99.0 release tomorrow. I plan to circle back and bump this PR to the next milestone then, but please let me know if you’d rather us work to include this PR in 1.99.0. Thanks 🙇 !

@geriux geriux self-assigned this Jul 5, 2023
@fluiddot
Copy link
Contributor

fluiddot commented Jul 6, 2023

Hey @geriux 👋. We will cut the 1.99.0 release tomorrow. I plan to circle back and bump this PR to the next milestone then, but please let me know if you’d rather us work to include this PR in 1.99.0. Thanks 🙇 !

Moving the PR to the next milestone as I'm about to cut the release.

@fluiddot fluiddot modified the milestones: 1.99.0 (22.8), 1.100.0 (22.9) Jul 6, 2023
@geriux geriux force-pushed the move-undo-redo-buttons branch from 05dc19c to 3bba3df Compare July 7, 2023 16:02
@geriux geriux force-pushed the move-undo-redo-buttons branch from debb122 to 148d1e7 Compare July 11, 2023 11:11
@geriux geriux merged commit 059025a into trunk Jul 11, 2023
@geriux geriux deleted the move-undo-redo-buttons branch July 11, 2023 14:01
This was referenced Jul 20, 2023
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derekblank derekblank derekblank approved these changes

Assignees

@geriux geriux

Labels
Project: Editor UX Improvements
Projects
None yet
Milestone
1.100.0 (22.9)
Development

Successfully merging this pull request may close these issues.
3 participants
@geriux @fluiddot @derekblank