Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mobile - Image block - Fix issue with set width and height images #5869

Conversation

wpmobilebot
Copy link
Collaborator

Related PRs

Description

This PR is generated by version-toolkit to downstream the changes for gutenberg submodule.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Jun 15, 2023

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

@geriux geriux requested a review from SiobhyB June 15, 2023 10:26
Copy link
Contributor

@SiobhyB SiobhyB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved via WordPress/gutenberg#51463 (review)

FYI: I re-ran a couple of the failing tests, I believe they're false positives.

@geriux
Copy link
Contributor

geriux commented Jun 15, 2023

FYI: I re-ran a couple of the failing tests, I believe they're false positives.

It keeps failing, I'll take a look just in case something is broken in trunk 🤔

…e-block-fixed-height-issue

# Conflicts:
#	gutenberg
@geriux geriux merged commit e408962 into trunk Jun 19, 2023
@geriux geriux deleted the version-toolkit/gutenberg/rnmobile/fix/image-block-fixed-height-issue branch June 19, 2023 16:47
@dcalhoun dcalhoun mentioned this pull request Jun 22, 2023
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants