Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show "No title"/"No description" placeholder for not belonged videos #5840

Merged
merged 3 commits into from
Jun 7, 2023
Merged

Show "No title"/"No description" placeholder for not belonged videos #5840

merged 3 commits into from
Jun 7, 2023

Conversation

fluiddot
Copy link
Contributor

@fluiddot fluiddot commented Jun 7, 2023 •
edited
Loading

Related to Automattic/jetpack#31134.

To test:
Follow testing instructions from Automattic/jetpack#31134.

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

@fluiddot fluiddot added [Type] Enhancement Improves a current area of the editor VideoPress block labels Jun 7, 2023
@fluiddot fluiddot added this to the 1.97.0 (22.6) milestone Jun 7, 2023
@fluiddot fluiddot requested review from jhnstn and SiobhyB June 7, 2023 08:36
@fluiddot fluiddot self-assigned this Jun 7, 2023
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Jun 7, 2023 •
edited
Loading

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

@fluiddot fluiddot force-pushed the videopress-no-description-placeholder branch from 1270c2d to 298bb35 Compare June 7, 2023 08:40
jhnstn
jhnstn approved these changes Jun 7, 2023
View reviewed changes
Copy link
Member

@jhnstn jhnstn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@fluiddot fluiddot enabled auto-merge June 7, 2023 14:45
@fluiddot fluiddot merged commit 27c5d8b into trunk Jun 7, 2023
@fluiddot fluiddot deleted the videopress-no-description-placeholder branch June 7, 2023 16:51
@jhnstn jhnstn mentioned this pull request Jun 14, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhnstn jhnstn jhnstn approved these changes

@SiobhyB SiobhyB Awaiting requested review from SiobhyB

Assignees

@fluiddot fluiddot

Labels
[Type] Enhancement Improves a current area of the editor VideoPress block
Projects
None yet
Milestone
1.97.0 (22.6)
Development

Successfully merging this pull request may close these issues.
2 participants
@fluiddot @jhnstn