Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RichText - Use parsed font size values when comparing new changes #4463

Merged
merged 1 commit into from
Jan 14, 2022

Conversation

geriux
Copy link
Contributor

@geriux geriux commented Jan 13, 2022

This PR fixes a bug within RichText, where in some cases it would generate a render loop when setting a new font-size value and this didn't match the parsed value.

To test check the Gutenberg PR description.

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Jan 13, 2022

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

@geriux geriux marked this pull request as ready for review January 13, 2022 17:07
Copy link
Contributor

@fluiddot fluiddot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved via WordPress/gutenberg#37951 (review).

NOTE: We might consider adding an entry to the release notes as this bugfix looks like a user-facing change.

@geriux
Copy link
Contributor Author

geriux commented Jan 14, 2022

NOTE: We might consider adding an entry to the release notes as this bugfix looks like a user-facing change.

I didn't add one since this will be included in a betafix, if I'm not mistaken, we don't add new entries for these cases right?

@geriux
Copy link
Contributor Author

geriux commented Jan 14, 2022

Thinking about it, I think that's the case for the main apps right? So we do include them in Gutenberg and Gutenberg Mobile but not in the main apps beta fixes since the changelog usually is already edited and translated, is that correct?

@fluiddot
Copy link
Contributor

Thinking about it, I think that's the case for the main apps right? So we do include them in Gutenberg and Gutenberg Mobile but not in the main apps beta fixes since the changelog usually is already edited and translated, is that correct?

Right, I guess that when the beta fix is cut, this change will be included under a new section for that version 👍 .

Regarding the changelog of the main apps, I think that's correct, we don't update it because usually the release notes had already been sent for translations before the beta fix is merged.

@geriux geriux merged commit 6751674 into develop Jan 14, 2022
@geriux geriux deleted the fix/font-size-loop branch January 14, 2022 15:25
@mkevins mkevins mentioned this pull request Jan 18, 2022
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants