-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add UI tests to unsupported block editor #2345
Conversation
Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job! |
Test that tapping on the help button of an unsupported block shows the bottom sheet. Tapping on the edit button in the bottom sheet shows the unsupported block web view editor.
ef43301
to
027f10f
Compare
I figured out why this PR fails when running locally, when it wasn't before. First of all, I remembered CircleCI now only runs canary tests by default—so CircleCI actually isn't running the tests I added in this PR (unless I manually run them from the peril comment above). As mentioned at the bottom of When I started this PR, its branch was based off #2063 (and WordPress/gutenberg#21150) at a time when the unsupported blocks UI was not behind a Now the question is, how to run UI tests on a feature that's behind a |
I found a fix using for iOS:
and Android
I don't know if there's a better solution. Otherwise, this is ready for testing again @etoledom and @marecar3. |
Closing in favor of WordPress/gutenberg#23729. Since the monorepo has been merged, UI test code now belongs in the Gutenberg repo. |
Addresses: #2358
Adds UI tests to the unsupported block editor.
Test that tapping on the help button of an unsupported block shows the bottom sheet. Tapping on the edit button in the bottom sheet shows the unsupported block web view editor.
To test:
yarn test:e2e:ios:local __device-tests__/gutenberg-editor-unsupported-blocks.test.js
)PR submission checklist:
RELEASE-NOTES.txt
if necessary.