-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a new empty para block on Enter.KEY #159
Merged
daniloercoli
merged 15 commits into
master
from
try/add-new-empty-block-after-focus-on-enter-key
Oct 16, 2018
Merged
Changes from 12 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
7c48f71
Add new empty block with test content on Enter.KEY
daniloercoli 31893ff
Fix lint
daniloercoli 33f0781
Fix flow hopefully, since cannot run it locally :(
daniloercoli b1387e5
Fix Flow
daniloercoli 33d8d63
FIX: Add the block in the middle if none has the focus. This is a tem…
daniloercoli 811a703
Update GB hash
daniloercoli a7807c9
Update GB hash
daniloercoli f45104d
Add TODO and better comment
daniloercoli adf0be2
Merge branch 'master' of https://github.com/wordpress-mobile/gutenber…
daniloercoli f9c7466
Update GB hash
daniloercoli 29b7aea
Fix lint
daniloercoli 40f58a8
Merge branch 'master' of https://github.com/wordpress-mobile/gutenber…
daniloercoli 9ea674a
Add a wrapper function to BlockHolder that passes the current blockID…
daniloercoli d1345fa
Remove unecessary method in BlockHolder, and introduce a wrapper in B…
daniloercoli 7db3427
Fix Flow: forgot to update PropsType
daniloercoli File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Submodule gutenberg
updated
68 files
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that since we're passing this function to each of the blocks, we can actually specialize it to accept the block
clientId
and emit an action to add the blocks after this specificclientId
. We won't need to rely on which block is selected at that moment. WDYT?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting...will try that!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! Just to expand a bit, we can make block-manager's
insertBlocksAfter
accept theclientID
but we can still pass a wrapped version down to the block-holder that only needs theblocks
parameter.