Switch to saving ci-checks-js.sh logs to logs/ folder

.buildkite/pipeline.yml

@@ -39,7 +39,7 @@ steps:
       echo "--- :node: Lint and Unit Tests"
       ./bin/ci-checks-js.sh
     artifact_paths:
-      - ./*-tests-out.log
+      - ./logs/*.log
 
   - label: "Build JS Bundles"
     depends_on: "unit-tests"

.gitignore

@@ -112,7 +112,7 @@ buck-out/
 #
 # These are generated only via `bin/ci-checks-js.sh`, so unlikely to appear on a dev machine.
 # Still, it's worth ignoring just to avoid these getting committed by accident while testing the CI workflow locally.
-*-test-out.log
+/logs/*
 
 # e2e output log
 appium-out.log

bin/ci-checks-js.sh

@@ -48,13 +48,15 @@ fi
 
 # Notice we forward the tests output to a file.
 # That's because they generates 70k+ lines and we don't want to pollute the logs like that.
+LOGS_DIR=./logs
+mkdir -p $LOGS_DIR
 if [ "$CHECK_TESTS" = true ] ; then
   # we'll run the tests twice (once for each platform) if the platform env var is not set
   if [[ -z "${TEST_RN_PLATFORM:-}" ]] ; then
     echo "--- :microscope: :android: Unit tests"
-    TEST_RN_PLATFORM=android npm run test --maxWorkers=4 > android-tests-out.log || pFail
+    TEST_RN_PLATFORM=android npm run test --maxWorkers=4 > "$LOGS_DIR/android-tests-out.log" || pFail
     echo "--- :microscope: :ios: Unit tests"
-    TEST_RN_PLATFORM=ios npm run test --maxWorkers=4 > ios-tests-out.log || pFail
+    TEST_RN_PLATFORM=ios npm run test --maxWorkers=4 > "$LOGS_DIR/ios-tests-out.log" || pFail
   else
     echo "--- :microscope: :$TEST_RN_PLATFORM: Unit tests"
     npm run test --maxWorkers=4 > "$TEST_RN_PLATFORM-tests-out.log" || pFail