Fixing/updating travis #4439
Merged
Fixing/updating travis #4439
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Code looks good to me @kwonye. Tested in the simulator, no problems. Ran the test suite, no problems. |
Contributor
Author
|
Thanks @aerych! |
Member
|
Since I renamed the enums in wordpress-mobile/WordPressCom-Analytics-iOS#38 should I change those strings as well or do they need to stay the same? |
Contributor
Author
They should be changed, but that doesn't have to be done until this repo is pulling 0.40 (right now it's on 0.39) |
koke
added a commit
that referenced
this pull request
Nov 12, 2015
As mentioned here #4439 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating to use Xcode 7.1 and deleting nonexistent import.
Also adds cases for 3D Touch in Tracks to fix a unit test.
Needs review: @aerych