Support most Post Settings on custom posts by crazytonyli · Pull Request #25274 · wordpress-mobile/WordPress-iOS

crazytonyli · 2026-02-20T05:34:36Z

Description

Here are the main changes in this PR:

You can now add a new post. It reuses the same FAB design in the regular posts.
PostTagsView is refactored to support returning selected tag/term id and name. Previously, it's just name. We need this change because the core REST API wants id.
The Post Settings are mostly implemented on custom posts. This requires most testing though, because there are many different kinds of custom posts, and some Post Settings may not supported on some custom post types.

Test Instructions

Try Post Settings on custom posts
Regression tests on the regular posts screen

dangermattic · 2026-02-20T05:35:11Z

	2 Warnings
⚠️	View files have been modified, but no screenshot or video is included in the pull request. Consider adding some for clarity.
⚠️	This PR is larger than 500 lines of changes. Please consider splitting it into smaller PRs for easier and faster reviews.

Generated by 🚫 Danger

wpmobilebot · 2026-02-20T05:43:57Z

🤖 Build Failure Analysis

This build has failures. Claude has analyzed them - check the build annotations for details.

wpmobilebot · 2026-02-26T02:18:51Z

📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.

	App Name	WordPress
	Configuration	Release-Alpha
	Build Number	`31212`
	Version	`PR #25274`
	Bundle ID	`org.wordpress.alpha`
	Commit	`2361b90`
	Installation URL	0vp1dhf6sm5c8

Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

wpmobilebot · 2026-02-26T02:18:58Z

📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.

	App Name	Jetpack
	Configuration	Release-Alpha
	Build Number	`31212`
	Version	`PR #25274`
	Bundle ID	`com.jetpack.alpha`
	Commit	`2361b90`
	Installation URL	3cmq51vhur0kg

Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

kean · 2026-02-26T20:14:45Z

WordPress/Classes/ViewRelated/NewGutenberg/CustomPostEditorViewController.swift

+        service: WordPressAPIInternal.PostService,
        client: WordPressClient,
-        post: AnyPostWithEditContext,
+        post: AnyPostWithEditContext?,


Can an editor be opened without a post? It needs to have an empty starting point. It seems that change resulted in increased complexity.

AnyPostWithEditContext is fetched from the server. A nil value indicates starting a new post.

kean · 2026-02-26T20:16:43Z

WordPress/Classes/ViewRelated/CustomPostTypes/CustomPostEditorService.swift

+
+extension CustomPostEditorService {
+    // Used in unit tests.
+    func inspectPendingSettings() -> PostSettings? {


(nit) could be a property

I intentionally made it a function named "inspect" because I don't think it should be used as a public API.

kean · 2026-02-26T20:17:08Z

WordPress/Classes/ViewRelated/CustomPostTypes/CustomPostEditorService.swift

+    }
+
+    /// Resolves `id == 0` tags by searching by name. Returns updated tag array.
+    private func resolveUnknownTagIDs(for tags: [PostSettings.Term]) async throws -> [PostSettings.Term] {


(nit) does it belong to the "editor" service?

Good point. It probably should be in the TagsService.

kean · 2026-02-26T20:23:53Z

WordPress/Classes/ViewRelated/CustomPostTypes/CustomPostEditorService.swift

+
+    /// Saves or publishes from post settings. Handles term resolution, optional
+    /// publish status override with editor content injection, and create-or-update branching.
+    func save(settings: PostSettings, publish: Bool) async throws {


(nit) It will probably be easier to follow as two separate methods.
(nit) It seems a bit backwards that it stores the settings using PostCreateParams. In the future, the editor will need to be able to support saving local revisions, etc. Shouldn't it simply store PostWithEditrContext with parameters applied locally and then generate "create" parameters from it?

I think there are many benefits in using different models for different contexts: AnyPostWithEditContext represents an immutable server post, so it should not be used to represent a local draft.

In the future, the editor will need to be able to support saving local revisions,

I haven't thought too much about it at the moment. Maybe we'll refactor once that's implemented, so we can do it properly?

kean · 2026-02-26T20:25:17Z

WordPress/Classes/ViewRelated/CustomPostTypes/CustomPostEditorService.swift

+    let service: WordPressAPIInternal.PostService
+    let taxonomies: [SiteTaxonomy]
+
+    weak var delegate: CustomPostEditorServiceDelegate?


(nit) This also seem a backwards. Maybe it's due to the name. It looks like it's more of a CustomPostEditorViewModel than a service.

I was thinking about CustomPostEditorSession. The name "session" is used in many Apple APIs, but not so much in this code base. So, I went with the old "service".

sonarqubecloud · 2026-02-27T05:56:27Z

Quality Gate passed

Issues
15 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
4.4% Duplication on New Code

See analysis details on SonarQube Cloud

kean · 2026-02-27T15:09:12Z

Thanks for the replies! I agree with the get it working -> refactor approach since it's entirely new code.

crazytonyli force-pushed the task/post-settings-refactor branch from c482a6f to 07358d1 Compare February 22, 2026 05:45

crazytonyli mentioned this pull request Feb 22, 2026

Add Post Settings to Custom Posts #25268

Merged

crazytonyli force-pushed the task/post-settings-terms branch from 3176a05 to 404d35a Compare February 23, 2026 07:48

Base automatically changed from task/post-settings-refactor to trunk February 24, 2026 00:02

crazytonyli force-pushed the task/post-settings-terms branch 2 times, most recently from 176d0cd to dbe79cb Compare February 24, 2026 06:24

Update wordpress-rs

0008e93

crazytonyli force-pushed the task/post-settings-terms branch from dbe79cb to ed4b166 Compare February 26, 2026 02:06

crazytonyli changed the title ~~Support taxonomy terms in custom post Post Settings~~ Support most Post Settings on custom posts Feb 26, 2026

Support adding new posts and custom terms

4eebb1f

crazytonyli force-pushed the task/post-settings-terms branch from ed4b166 to 4eebb1f Compare February 26, 2026 03:40

crazytonyli requested a review from kean February 26, 2026 03:40

crazytonyli added the Custom Post Types label Feb 26, 2026

crazytonyli added this to the 26.8 milestone Feb 26, 2026

crazytonyli marked this pull request as ready for review February 26, 2026 03:40

kean reviewed Feb 26, 2026

View reviewed changes

crazytonyli requested a review from kean February 26, 2026 22:51

Extract term resolution into TermResolutionService

2361b90

kean approved these changes Feb 27, 2026

View reviewed changes

Conversation

crazytonyli commented Feb 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Test Instructions

Uh oh!

dangermattic commented Feb 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wpmobilebot commented Feb 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🤖 Build Failure Analysis

Uh oh!

wpmobilebot commented Feb 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wpmobilebot commented Feb 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sonarqubecloud bot commented Feb 27, 2026

Quality Gate passed

Uh oh!

kean commented Feb 27, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

crazytonyli commented Feb 20, 2026 •

edited

Loading

dangermattic commented Feb 20, 2026 •

edited

Loading

wpmobilebot commented Feb 20, 2026 •

edited

Loading

wpmobilebot commented Feb 26, 2026 •

edited

Loading

wpmobilebot commented Feb 26, 2026 •

edited

Loading