Skip to content

Fix compilation issues#25224

Queued
crazytonyli wants to merge 2 commits intotrunkfrom
fix-compilation-issues
Queued

Fix compilation issues#25224
crazytonyli wants to merge 2 commits intotrunkfrom
fix-compilation-issues

Conversation

@crazytonyli
Copy link
Contributor

Description

Fix prototype build failures on CI

[18:52:59]: ▸ ❌ /opt/ci/builds/builder/automattic/wordpress-ios/Modules/Sources/JetpackStats/Charts/BarChartView.swift:328:31: type 'ChartData' has no member 'previewExamples'
[18:52:59]: ▸             ForEach(ChartData.previewExamples) { example in
[18:52:59]: ▸                     ~~~~~~~~~ ^~~~~~~~~~~~~~~
[18:52:59]: ▸ ❌ /opt/ci/builds/builder/automattic/wordpress-ios/Modules/Sources/JetpackStats/Charts/BarChartView.swift:329:37: cannot convert value of type 'Binding<Subject>' to expected argument type 'String'
[18:52:59]: ▸                 previewCard(example.title) {
[18:52:59]: ▸                                     ^
[18:52:59]: ▸ ❌ /opt/ci/builds/builder/automattic/wordpress-ios/Modules/Sources/JetpackStats/Charts/BarChartView.swift:330:48: cannot convert value of type 'Binding<Subject>' to expected argument type 'ChartData'
[18:52:59]: ▸                     BarChartView(data: example.data)
[18:52:59]: ▸                                                ^
[18:52:59]: ▸ ❌ /opt/ci/builds/builder/automattic/wordpress-ios/Modules/Sources/JetpackStats/Charts/BarChartView.swift:331:64: cannot convert value of type 'Binding<Subject>' to expected argument type 'Bool'
[18:52:59]: ▸                         .environment(\.showComparison, example.showComparison)
[18:52:59]: ▸                                                                ^
[18:52:59]: ▸ ❌ /opt/ci/builds/builder/automattic/wordpress-ios/Modules/Sources/JetpackStats/Charts/BarChartView.swift:328:13: generic parameter 'C' could not be inferred
[18:52:59]: ▸             ForEach(ChartData.previewExamples) { example in
[18:52:59]: ▸             ^
[18:52:59]: ▸ ❌ /opt/ci/builds/builder/automattic/wordpress-ios/Modules/Sources/JetpackStats/Charts/LineChartView.swift:258:31: type 'ChartData' has no member 'previewExamples'
[18:52:59]: ▸             ForEach(ChartData.previewExamples) { example in
[18:52:59]: ▸                     ~~~~~~~~~ ^~~~~~~~~~~~~~~
[18:52:59]: ▸ ❌ /opt/ci/builds/builder/automattic/wordpress-ios/Modules/Sources/JetpackStats/Charts/LineChartView.swift:259:37: cannot convert value of type 'Binding<Subject>' to expected argument type 'String'
[18:52:59]: ▸                 previewCard(example.title) {
[18:52:59]: ▸                                     ^
[18:52:59]: ▸ ❌ /opt/ci/builds/builder/automattic/wordpress-ios/Modules/Sources/JetpackStats/Charts/LineChartView.swift:260:49: cannot convert value of type 'Binding<Subject>' to expected argument type 'ChartData'
[18:52:59]: ▸                     LineChartView(data: example.data)
[18:52:59]: ▸                                                 ^
[18:52:59]: ▸ ❌ /opt/ci/builds/builder/automattic/wordpress-ios/Modules/Sources/JetpackStats/Charts/LineChartView.swift:261:64: cannot convert value of type 'Binding<Subject>' to expected argument type 'Bool'
[18:52:59]: ▸                         .environment(\.showComparison, example.showComparison)
[18:52:59]: ▸                                                                ^
[18:52:59]: ▸ ❌ /opt/ci/builds/builder/automattic/wordpress-ios/Modules/Sources/JetpackStats/Charts/LineChartView.swift:258:13: generic parameter 'C' could not be inferred
[18:52:59]: ▸             ForEach(ChartData.previewExamples) { example in
[18:52:59]: ▸             ^

@crazytonyli crazytonyli added this to the 26.7 milestone Feb 5, 2026
@crazytonyli crazytonyli requested a review from kean February 5, 2026 04:41
@dangermattic
Copy link
Collaborator

1 Warning
⚠️ View files have been modified, but no screenshot or video is included in the pull request. Consider adding some for clarity.

Generated by 🚫 Danger

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Feb 5, 2026

App Icon📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress
ConfigurationRelease-Alpha
Build Number30804
VersionPR #25224
Bundle IDorg.wordpress.alpha
Commit78efb86
Installation URL0sts8b41h4638
Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Feb 5, 2026

App Icon📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack
ConfigurationRelease-Alpha
Build Number30804
VersionPR #25224
Bundle IDcom.jetpack.alpha
Commit78efb86
Installation URL38fof9j32en80
Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Feb 5, 2026

🤖 Build Failure Analysis

This build has failures. Claude has analyzed them - check the build annotations for details.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 5, 2026

Quality Gate Failed Quality Gate failed

Failed conditions
66.7% Duplication on New Code (required ≤ 10%)

See analysis details on SonarQube Cloud

@crazytonyli crazytonyli enabled auto-merge February 5, 2026 08:13
@crazytonyli crazytonyli added this pull request to the merge queue Feb 5, 2026
Any commits made after this event will not be merged.
github-merge-queue bot pushed a commit that referenced this pull request Feb 5, 2026
* Fix compilation issues

* Remove the os version argument
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants