-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Support editing custom posts #25208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: prototype-custom-post-types
Are you sure you want to change the base?
Support editing custom posts #25208
Changes from all commits
3d80d4b
efa5e8d
1082694
ac6d26f
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -39,7 +39,7 @@ final class CommentGutenbergEditorViewController: UIViewController { | |
| // doesn't need network access | ||
| let configuration = EditorConfigurationBuilder( | ||
| content: initialContent ?? "", | ||
| postType: "comment", | ||
| postType: .init(postType: "comment", restBase: "comments"), // FIXME: "comment" is not a post type. | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. If we feel compelled to "fix" the post type, we might also consider fixing the site URL and API root. GBK currently requires all of these, but effectively discards them when "offline mode" is enabled. For context, this comment editor is currently unused. |
||
| siteURL: URL(string: "https://offline.local")!, | ||
| siteApiRoot: URL(string: "https://offline.local/wp-json")! | ||
| ) | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When we are ready, we can integrate a GBK prerelease. We'll publish the prerelease via
make release VERSION_TYPE=preminor DRY_RUN=trueon GBK's trunk branch.