Skip to content

Only lookup local post when quering with "wp_jp_foreign_id" #24586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: trunk
Choose a base branch
from

Conversation

crazytonyli
Copy link
Contributor

Description

The wp_jp_foreign_id is introduced to associate local posts with posts in the WordPress site. In that process, we should only look up local posts. This PR adds a condition to only query local posts.

wp_jp_foreign_id is asavednot a unique id. Multiple posts may have the same "foreign id". I'm not exactly sure how to do that, but I think it's possible that some plugins have a feature to copy/duplicate a post which copies the post's custom fields too.

Testing instructions

Verify no regression on this issue: pe7hp4-N2-p2#comment-322

@dangermattic
Copy link
Collaborator

1 Warning
⚠️ This PR is assigned to the milestone 26.0. The due date for this milestone has already passed.
Please assign it to a milestone with a later deadline or check whether the release for this milestone has already been finished.

Generated by 🚫 Danger

Copy link

@wpmobilebot
Copy link
Contributor

App Icon📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress
ConfigurationRelease-Alpha
Build Number27836
VersionPR #24586
Bundle IDorg.wordpress.alpha
Commit2253665
Installation URL76pe84smgoo78
Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@wpmobilebot
Copy link
Contributor

App Icon📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack
ConfigurationRelease-Alpha
Build Number27836
VersionPR #24586
Bundle IDcom.jetpack.alpha
Commit2253665
Installation URL4ek0fmerfdq18
Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants