Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blogging Prompts Feature Introduction: update lightbulb icon #18320

Merged
merged 1 commit into from
Apr 8, 2022

Conversation

ScoutHarris
Copy link
Contributor

Ref: #18176
Depends on: #18304

The lightbulb Material icon is now used in the Blogging Prompts feature introduction header instead of the SF Symbol.

To test:

  • Enable bloggingPrompts feature flag.
  • Run the app.
  • When the app launches, the Feature Introduction will appear.
  • Verify the updated lightbulb icon is displayed.
Before After
before after

Regression Notes

  1. Potential unintended areas of impact
    N/A

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    N/A

  3. What automated tests I added (or what prevented me from doing so)
    N/A

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@wpmobilebot
Copy link
Contributor

You can test the changes in Jetpack from this Pull Request by:
  • Clicking here or scanning the QR code below
  • Then installing the build number pr18320-e72e2fa from App Center on your iPhone

The .ipa file can also be downloaded directly here.
If you need access to App Center, please ask a maintainer to add you.

@wpmobilebot
Copy link
Contributor

You can test the changes in WordPress from this Pull Request by:
  • Clicking here or scanning the QR code below
  • Then installing the build number pr18320-e72e2fa from App Center on your iPhone

The .ipa file can also be downloaded directly here.
If you need access to App Center, please ask a maintainer to add you.

Copy link
Contributor

@dvdchr dvdchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Base automatically changed from feature/18176-fi_optional_header_image to trunk April 8, 2022 19:16
@ScoutHarris
Copy link
Contributor Author

Thanks @dvdchr !

@ScoutHarris ScoutHarris merged commit ff18d7d into trunk Apr 8, 2022
@ScoutHarris ScoutHarris deleted the feature/18176-lightbulb_icon branch April 8, 2022 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants