Skip to content

Conversation

@etoledom
Copy link
Contributor

@etoledom etoledom commented Aug 1, 2019

This PR is the WPiOS side of: wordpress-mobile/WordPress-Android#10300

Add additional properties to gutenberg_enabled , and gutenberg_disabled analytics events:
The property source can now have the following values:

  • via-site-settings
  • on-block-post-open
  • on-site-creation

Disclosure:
With this changes, are not tracking the switch event in cases where:

  • We are setting Gutenberg/Aztec as part of a migration
  • We are setting Gutenberg/Aztec as part of sync with remote
  • We are setting Aztec as the default value

Is this the proper behavior? cc @daniloercoli @hypest

To test:

Test 1:

  • Flip the block editor setting in Site settings and make sure the property is added correctly

Test 2:

  • Create a new site, and make sure the property is added with the correct value
  • Tap on new post, and make sure nothing is tracked

Test 3:

  • Clear your editor settings on the web
  • Re-install the app
  • open a block based post
  • the popup should appear, and the correct property value bumped with analytics

Update release notes:

  • If there are user facing changes, I have added an item to RELEASE-NOTES.txt.

@etoledom etoledom added the Gutenberg Editing and display of Gutenberg blocks. label Aug 1, 2019
@etoledom etoledom added this to the 13.0 ❄️ milestone Aug 1, 2019
@etoledom etoledom self-assigned this Aug 1, 2019
@etoledom etoledom requested a review from koke August 1, 2019 17:46
@etoledom etoledom marked this pull request as ready for review August 1, 2019 17:47
@etoledom etoledom merged commit 0a0a859 into release/13.0 Aug 5, 2019
@etoledom etoledom deleted the issue/gutenberg-tracks-opt-in branch August 5, 2019 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Gutenberg Editing and display of Gutenberg blocks.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants