Rename Blog.isHostedAtWPcom for clarity

[guarani]

Expected behavior

By its name alone, one would expect Blog.isHostedAtWPcom to be true for all WordPress.com sites, whether or not they have plugins installed. It's not true in this scenario, because it's actually just an indication of whether or not Jetpack is installed. So it would be better to rename it to make this clearer.

Actual behavior

Blog.isHostedAtWPcom is false for WordPress.com sites with plugins installed because it's actually just the negation of !blog.jetpack.

The current naming is likely the reason @-mentions is disabled on WordPress.com sites with plugins installed. So there are likely real negative consequences to keeping the current naming.

Steps to reproduce the behavior

1. Log into WPiOS and choose a WordPress.com site that has plugins installed (requires paid plan).
2. Put a breakpoint on the following line and observe that isHostedOnWPcom is false/0:
   

   WordPress-iOS/WordPress/Classes/Services/BlogService.m

   Line 723 in b347ef8

   blog.isHostedAtWPcom = !remoteBlog.jetpack;

Proposed solution

I think we should rename it to Blog.isWPComSimpleSite. This would involve renaming the variable in code as well as in the Core Data data model.

Tested on iPhone, iOS 14, WPiOS 6895ab8

[guarani]

I've also noticed WordPress.com sites with plugins installed can't be switched to private using WPiOS but can be switched using WPAndroid. This happens because of:

WordPress-iOS/WordPress/Classes/Models/Blog.m

Lines 504 to 506 in 8bfca46

	case BlogFeaturePrivate:
	// Private visibility is only supported by wpcom blogs
	return [self isHostedAtWPcom];

_{Tested on WPiOS 15.8 and WPAndroid 15.9 (beta)}

[guarani]

WPiOS doesn't show a Language option on the Settings screen (I'd expect to see it under the GENERAL section, below Time Zone) for WordPress.com sites with plugins installed.
Interestingly, neither does WPAndroid.

Based on the following comment though, I think the fact that the Language option is not present might be an oversight:

WordPress-iOS/WordPress/Classes/ViewRelated/Blog/Site Settings/SiteSettingsViewController.m

Lines 237 to 240 in 50e1647

	// Privacy and Language are only available for WordPress.com admins
	if (!self.blog.supportsSiteManagementServices) {
	rowCount -= 2;
	}

[stale]

This issue has been marked as stale because:

• It has been inactive for the past year.
• It isn't in a project or a milestone.
• It hasn’t been labeled [Pri] Blocker, [Pri] High, or good first issue.

Please comment with an update if you believe this issue is still valid or if it can be closed. This issue will also be reviewed for validity and priority during regularly scheduled triage sessions.