Media Sharing - Latitude Column Fix #26
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduced UI to list domain suggestions.
…ng toast after back-dating a scheduled post on top anchor now
…id into issue/9452-domain-suggestions
…id into issue/9452-domain-suggestions # Conflicts: # WordPress/src/main/res/values/colors.xml
…id into issue/9452-domain-suggestions
…id into issue/9815-email-verification-reminder # Conflicts: # WordPress/src/main/java/org/wordpress/android/ui/domains/DomainRegistrationDetailsFragment.kt # WordPress/src/main/java/org/wordpress/android/ui/domains/DomainRegistrationResultFragment.kt # WordPress/src/main/java/org/wordpress/android/ui/main/MySiteFragment.java
…-editor Clean up after legacy editor
The content of the hint announcement and the text of the TextViews are the same so the announcement is duplicated so the hint is disabled in favor of the text since it will be updated and truly reflect the state of the targeted setting. The headers are now marked as accessibility headers for easier header navigation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10843
Findings
This crash is occurring because, in API 29, they depreciated the latitude column.
So the query is currently calling for all columns including the depreciated column even though it isn't used.
Solution
To specify the column that is needed by the query so that the depreciated columns are no longer accessed.
Testing
Note: I haven't reproduced the fix as yet. I am resolving an API error so this hasn't been tested.
Reviewing
Only 1 reviewer is needed but anyone can review.
Submitter Checklist
RELEASE-NOTES.txtif necessary.