-
Notifications
You must be signed in to change notification settings - Fork 3
Merge Woo Signin M1 login flow changes #22
Conversation
The new login flow for Woo has the login by site screen leading to this view so it doesn't make any sense having the option available as it would essentially be routing the user back to the previous screen.
This reverts commit d8a0f33d. Turns out this part is not yet feasible so we'll skip it for now.
This new mode is for the Woo Android app.
…far too much cleanup.
…in-lib # Conflicts: # libs/login/WordPressLoginFlow/build.gradle # libs/login/WordPressLoginFlow/src/main/java/org/wordpress/android/login/LoginUsernamePasswordFragment.java # libs/login/gradle.properties-example
|
Thanks @AmandaRiu! I've tested the changes in WPAndroid and it works as expected. @aforcier I'm not sure what to look out for in these "subtree" pull/push PRs. Any tips? Eg. Can I somehow double-check it wasn't pulled/pushed using the buggy version of git? |
|
Thanks @AmandaRiu & @malinajirka! @malinajirka generally the big thing is to look for client-specific things that maybe don't need to be exposed to the library. For instance, I'm not sure the flow needs to be called Other than that, making sure it builds independently (we have CI for that 👍), and checking the integration with the rest of the client apps (you've both done that) are the main things.
First, note that the buggy version of git fails when pushing, but not when pulling. So if the changes have been pushed to the login library, they're probably okay. We should check anyway, but just an FYI of what behavior to expect while this is still a problem with git 😔 Regardless, you can test it by then pulling these changes from a client app:
Otherwise, you should be okay. (You can see where I did that to test an earlier PR that did use a bad git version: wordpress-mobile/WordPress-Android#10149 (comment)) |
malinajirka
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the detailed instructions @aforcier ! ;)
All seems good to me, thanks @AmandaRiu ;)! 🚢
Merge Woo Signin M1 login flow changes
This PR merges the
woocommerce-androidchanges to the login library from this PR - which includes detailed documentation on what changed in the Woo login flow, including screenshots.Every effort was made to not effect WPAndroid's use of the login library during this project, but there were a handful of new interface methods and strings added. I've opened a draft PR on WordPress-Android that merges the changes from this branch, as well as implements the interface methods so WPAndroid can be fully tested before this branch is merged, and includes recommended testing scenarios.