This repository was archived by the owner on Feb 4, 2025. It is now read-only.
Revert "[ANR fix] Move UserAgent initialization to a background thread" #3101
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hichamboushaba
commented
Sep 24, 2024
| } | ||
|
|
||
| @Provides | ||
| @Singleton |
Member
Author
There was a problem hiding this comment.
I'm leaving the revert as is (which means reverting this part also), if we find out that the revert fixes the issue, I'll create a separate PR to make the UserAgent singleton for the example app, otherwise if we need to bring back the changes, reverting this PR will be easier if we keep all the changes.
4 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In WCAndroid, we are getting some crashes related to WebView usage from multiple processes since 19.7, which was the version where we introduced the change of #3067.
The changes of the linked PR shouldn't cause these crashes, but we want to experiment with reverting them to confirm if there are any unwanted side effects that they caused.
For more information on the crashes, check peaMlT-Tk-p2
Testing
I think green CI should be enough for this,
and we don't need a PR to update FluxC on WCAndroid either, it will be done by the release manager during the code freeze.scratch this, I'll create a PR to update the reference on WCAndroid to make sure a release note about the change is included, I'll do it when this PR is merged.