Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on woocommerce/woocommerce-android#2630, I noticed a few issues when displaying a group of products. This PR attempts to fix those issues.
groupedProductIds
should beLong
since theremoteProductId
isLong
everywhere in the app. So modifiedWCProductModel
to reflect this change in e2b7a4f.groupedProductIds
, I noticed that we delete the previously stored products from the local db before adding these products. This means in the woo app, the Products tab only displays the groupedProducts and we need to manually refresh the app to fetch the list of products again. So I have added logic to delete the locally stored products only if theremoteProductIds
are null.To test