Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Woo/grouped products small fixes #1668

Merged
merged 3 commits into from
Aug 17, 2020
Merged

Conversation

anitaa1990
Copy link
Contributor

While working on woocommerce/woocommerce-android#2630, I noticed a few issues when displaying a group of products. This PR attempts to fix those issues.

  • The list of groupedProductIds should be Long since the remoteProductId is Long everywhere in the app. So modified WCProductModel to reflect this change in e2b7a4f.
  • When fetching the product details for a list of groupedProductIds, I noticed that we delete the previously stored products from the local db before adding these products. This means in the woo app, the Products tab only displays the groupedProducts and we need to manually refresh the app to fetch the list of products again. So I have added logic to delete the locally stored products only if the remoteProductIds are null.

To test

  • Verify that Fetching products, fetching a single product and updating grouped products works as expected.

Copy link
Contributor

@0nko 0nko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@0nko 0nko merged commit 47a2177 into develop Aug 17, 2020
@0nko 0nko deleted the woo/grouped-products-small-fixes branch August 17, 2020 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants