This repository was archived by the owner on Feb 4, 2025. It is now read-only.
Add methods for getting locally changed Posts and Pages #1303
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Additional locally-changed tests will be added shortly.
4 tasks
shiki
commented
Jul 8, 2019
example/src/test/java/org/wordpress/android/fluxc/page/PageStoreLocalChangesTest.kt
Show resolved
Hide resolved
shiki
commented
Jul 8, 2019
example/src/test/java/org/wordpress/android/fluxc/page/PageStoreLocalChangesTest.kt
Outdated
Show resolved
Hide resolved
Contributor
Author
|
Leaving this open even if wordpress-mobile/WordPress-Android#10177 was canceled. We might need this in the near future. |
Contributor
|
Adding "Do not merge" label as the whole "auto-upload/save" feature has been put on hold until we decide how to proceed. |
malinajirka
reviewed
Jul 22, 2019
Contributor
malinajirka
left a comment
malinajirka
left a comment
There was a problem hiding this comment.
Thank you @shiki !
The code works as expected. However, I've added a comment which I'd like to clarify before we merge it into develop.
Note: Auto-upload/save feature has green again! ;)
fluxc/src/main/java/org/wordpress/android/fluxc/persistence/PostSqlUtils.java
Show resolved
Hide resolved
The premise is that this new name implies that it’s not related to `isLocallyChanged`. We will be less surprised that it uses both `isLocallyChanged` and `hasLocalChanges` conditions in the query.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a dependency of wordpress-mobile/WordPress-Android#10177.
This adds the methods
PostStore.getLocallyChangedPostsandPageStore.getLocallyChangedPages.Testing
Reviewing
Only 1 reviewer is needed but anyone can review.