Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Android Test build errors caused by Gutenberg change #9882

Merged
merged 1 commit into from
May 17, 2019

Conversation

jtreanor
Copy link
Contributor

The changes from #9644 are causing build errors for our connected tests. You can see the failure on CircleCI here.

The problem is that the new compileOptions entry
isn't playing nicely with the Android tests. I'm not sure why this is. Since the setting is only needed when building from source, I have added a conditional check around it.

Note: assembleVanillaDebugAndroidTest will still fail when building Gutenberg from source. I tried moving the Gradle config to WordPressEditor but that didn't work.

To test:

With wp.BUILD_GUTENBERG_FROM_SOURCE=false:

  • ./gradlew WordPress:assembleVanillaDebug
  • ./gradlew WordPress:assembleVanillaDebugAndroidTest

With wp.BUILD_GUTENBERG_FROM_SOURCE=true:

  • ./gradlew WordPress:assembleVanillaDebug

Update release notes:

  • If there are user facing changes, I have added an item to RELEASE-NOTES.txt.

@jtreanor jtreanor added Gutenberg Editing and display of Gutenberg blocks. Tooling labels May 17, 2019
@jtreanor jtreanor added this to the 12.5 milestone May 17, 2019
@jtreanor jtreanor requested review from hypest and mzorz and removed request for hypest May 17, 2019 10:38
Copy link
Contributor

@mzorz mzorz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :shipit:

@mzorz mzorz merged commit f89cefb into develop May 17, 2019
@mzorz mzorz deleted the fix/android-test-build-failure branch May 17, 2019 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Gutenberg Editing and display of Gutenberg blocks. Tooling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants