Fix #9826: make sure we Play Services are available before running the email hint picker. #9831
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e email hint picker
daniloercoli
approved these changes
May 10, 2019
Contributor
daniloercoli
left a comment
daniloercoli
left a comment
There was a problem hiding this comment.
Tested on the S9 emulator and it fixed the crash.
Also smoke tested the app and didn't find any problem.
daniloercoli
deleted the
issue/9826-fix-for-9.0-devices-without-play-services-installed
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #9826: make sure we Play Services are available before running the email hint picker.
The app won't crash, but there is some known limitations:
Note: I checked did a quick check of places where
GoogleApiClientwas used and I also ran the app and do a manual check of most features.