Update DialogHolder to use UiString #9084
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates
DialogHolderto useUiStringinstead ofStringRes Intto make it easier and more structured to use either string resources and regular strings easily. It makes it so that each string is known to be either a resource or a regular string, but never both or never neither. InjectedUiHelpersis passed in to increase testability ofDialogHoldereven though it currently doesn't have tests. (maybe an improvement for the future)To test:
Blog PostsPublishbutton and verify the dialog shows up as expected (Title, message, button names are still correct)Trashbutton and verify the dialog shows up as expected (Title, message, button names are still correct)Update release notes:
RELEASE-NOTES.txt.