Skip to content

Conversation

@jtreanor
Copy link
Contributor

@jtreanor jtreanor commented Jan 23, 2019

Although CircleCI is pretty stable, there have been occasional failures (e.g. here and here) caused by out of memory errors.

This adds some explicit options to keep Gradle under control when running on CircleCI. It includes a workaround for a Kotlin compiler crash (https://youtrack.jetbrains.com/issue/KT-15562).

Its possible the memory config is a bit conservative (only 1.5GB) but I would rather have it stable and increase from there to get better performance.

To test:

  • See that CircleCI is green on this PR. We will only get true confidence in this if it proves to be robust over time.

Update release notes:

  • If there are user facing changes, I have added an item to RELEASE-NOTES.txt.

Copy link
Contributor

@loremattei loremattei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CircleCI is green :-)

:shipit:

@jtreanor jtreanor merged commit 5525ffd into develop Jan 23, 2019
@jtreanor jtreanor deleted the circleci-memory-config branch January 23, 2019 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants