Skip to content

Gravatar permission-denied analytics #4233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 16, 2016
Merged

Gravatar permission-denied analytics #4233

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7b1157b
Track the Gravatar permissions interrupted case
hypest Jun 15, 2016
f1ca799
Track denied permissions in Gravatar update
hypest Jun 15, 2016
7b17f8e
Track all granted or denied Gravatar permissions
hypest Jun 16, 2016
c1ebb4c
Remove uneeded null check
hypest Jun 16, 2016
f5f27c0
"none" instead of empty if granted list is empty
hypest Jun 16, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 27 additions & 11 deletions WordPress/src/main/java/org/wordpress/android/ui/main/MeFragment.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,11 @@
import java.io.IOException;
import java.lang.ref.WeakReference;
import java.text.SimpleDateFormat;
import java.util.ArrayList;
import java.util.Date;
import java.util.HashMap;
import java.util.List;
import java.util.Map;
import java.util.TreeMap;

import de.greenrobot.event.EventBus;
Expand Down Expand Up @@ -428,21 +432,33 @@ public void onRequestPermissionsResult(int requestCode, @NonNull String permissi
grantResults) {
switch (requestCode) {
case CAMERA_AND_MEDIA_PERMISSION_REQUEST_CODE:
for (int grantResult : grantResults) {
if (grantResult == PackageManager.PERMISSION_DENIED) {
if (permissions.length == 0) {
AnalyticsTracker.track(AnalyticsTracker.Stat.ME_GRAVATAR_PERMISSIONS_INTERRUPTED);
} else {
List<String> granted = new ArrayList<>();
List<String> denied = new ArrayList<>();

for (int i = 0; i < grantResults.length; i++) {
if (grantResults[i] == PackageManager.PERMISSION_GRANTED) {
granted.add(permissions[i]);
} else {
denied.add(permissions[i]);
}
}

if (denied.size() == 0) {
AnalyticsTracker.track(AnalyticsTracker.Stat.ME_GRAVATAR_PERMISSIONS_ACCEPTED);
askForCameraOrGallery();
} else {
ToastUtils.showToast(this.getActivity(), getString(R.string
.gravatar_camera_and_media_permission_required), ToastUtils.Duration.LONG);

AnalyticsTracker.track(AnalyticsTracker.Stat
.ME_GRAVATAR_PERMISSIONS_DENIED);

return;
Map<String, Object> properties = new HashMap<>();
properties.put("permissions granted", granted.size() == 0 ? "[none]" : TextUtils
.join(",", granted));
properties.put("permissions denied", TextUtils.join(",", denied));
AnalyticsTracker.track(AnalyticsTracker.Stat.ME_GRAVATAR_PERMISSIONS_DENIED, properties);
}
}

AnalyticsTracker.track(AnalyticsTracker.Stat.ME_GRAVATAR_PERMISSIONS_ACCEPTED);

askForCameraOrGallery();
break;
}
}
Expand Down
1 change: 1 addition & 0 deletions ...cs/WordPressAnalytics/src/main/java/org/wordpress/android/analytics/AnalyticsTracker.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,7 @@ public enum Stat {
ME_ACCESSED,
ME_GRAVATAR_TAPPED,
ME_GRAVATAR_TOOLTIP_TAPPED,
ME_GRAVATAR_PERMISSIONS_INTERRUPTED,
ME_GRAVATAR_PERMISSIONS_DENIED,
ME_GRAVATAR_PERMISSIONS_ACCEPTED,
ME_GRAVATAR_SHOT_NEW,
Expand Down
4 changes: 4 additions & 0 deletions ...ressAnalytics/src/main/java/org/wordpress/android/analytics/AnalyticsTrackerMixpanel.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -874,6 +874,10 @@ private AnalyticsTrackerMixpanelInstructionsForStat instructionsForStat(
instructions = AnalyticsTrackerMixpanelInstructionsForStat.
mixpanelInstructionsForEventName("Me - Tapped Gravatar Tooltip");
break;
case ME_GRAVATAR_PERMISSIONS_INTERRUPTED:
instructions = AnalyticsTrackerMixpanelInstructionsForStat.
mixpanelInstructionsForEventName("Me - Gravatar Permissions Interrupted");
break;
case ME_GRAVATAR_PERMISSIONS_DENIED:
instructions = AnalyticsTrackerMixpanelInstructionsForStat.
mixpanelInstructionsForEventName("Me - Gravatar Permissions Denied");
Expand Down
3 changes: 3 additions & 0 deletions ...dPressAnalytics/src/main/java/org/wordpress/android/analytics/AnalyticsTrackerNosara.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -435,6 +435,9 @@ public void track(AnalyticsTracker.Stat stat, Map<String, ?> properties) {
case ME_GRAVATAR_TOOLTIP_TAPPED:
eventName = "me_gravatar_tooltip_tapped";
break;
case ME_GRAVATAR_PERMISSIONS_INTERRUPTED:
eventName = "me_gravatar_permissions_interrupted";
break;
case ME_GRAVATAR_PERMISSIONS_DENIED:
eventName = "me_gravatar_permissions_denied";
break;
Expand Down