Feature/posting improvements #399

roundhill · 2013-12-04T23:45:05Z

Updates and fixes to the post editor. Fixes some issues related to posting (issue should be tagged in commit). Quite a few changes:

A ViewPager was added to EditPostActivity to add separate views for post content, settings and preview.
Optimized some of the methods that have to do with rich text formatting to use far less code to accomplish the same task.
Tapping in the content area now goes 'full screen' by hiding the action bar and showing only the content area.
'Post Settings' button added at the bottom of the content area that moves to the settings view when tapped.
'Post Preview' icon added to action bar that loads post preview.
Fixes for picking media from other apps (such as dropbox).

…#46.

…ncreased size of title EditText font to differentiate it more.

…ost content, settings and preview.

…ust loop through all spans instead of checking for each individual class.

…r less code but accomplish the same task.

* ActionBar now hides when full screen editing. * Dismissing soft keyboard when full screen editing will dismiss the full screen editor. * Animation improvements.

Conflicts: res/values/strings.xml src/org/wordpress/android/ui/posts/PostsListFragment.java

…hod.

* Removed all extra instances of the post object. Instead, fragments will use use getPost() from the main activity. * Use an onTouch listener for determining when to go to full screen editing mode.

…ence.

…#232.

… keyboard was not showing.

Conflicts: src/org/wordpress/android/ui/posts/PostsActivity.java src/org/wordpress/android/ui/posts/PostsListFragment.java

Fixed issue where selecting images from G+ photos was not working.

* Added Post Settings button that shows at bottom of post content fragment. * Post preview button added to ActionBar * Added fade animation when entering and leaving full screen editor so it is less jarring.

* Made toggle buttons a minimum dp size to be easily tappable. * No more gradients and rounded corners :)

Conflicts: res/values/strings.xml

…Preview.

…external image.

@ShiftLeftLogical

…re made. Props @ShiftLeftLogical.

…ndroid gallery (like Dropbox). * Fixed posts list from not refreshing after saving a draft.

nbradbury · 2013-12-05T11:26:11Z

Dan, some really slick changes here. I like the ViewPager approach, and the way the content goes full-screen when you start editing is great. A few issues:

Selecting a photo from the gallery returns to the post editor with both the keyboard and ActionBar hidden (I think the keyboard should remain visible).
If the keyboard isn't showing and you tap in the first few lines of text, the tap point is scrolled out of view.
When editing an existing post that contains a photo, the photo appears correctly in the editor. If you tap to preview the post then hit the back button, you're returned to the editor but instead of a photo you see an HTML img tag
When editing the published date, the screen turns white when the date picker appears (doesn't happen with the time picker, though). If you hit the back button when the date picker appears, instead of canceling it shows the time picker. If you click Done on the date picker then click Done on the time picker, the time picker appears once again.
Seems like post settings could be even better organized, so that the most commonly-used items are at the top. Perhaps move categories, excerpt & password below the other items?
If you tap "Quick Photo" in the drawer but cancel out of the camera, you're still taken to the post editor with a new post showing.

roundhill · 2013-12-05T19:04:25Z

Thanks Nick! I'll get to work fixing those issues.

…the post preview.

…alogs with DatePicker and TimePicker widgets in them. Fixes #405 See: http://stackoverflow.com/questions/11383592/android-android-4-1-emulator-invoking-ondateset-twice-from-datepicker-dialog and http://stackoverflow.com/questions/11444238/jelly-bean-datepickerdialog-is-there-a-way-to-cancel/

…the Title field. Fixes #404.

…t the top. Also removed some unnecessary styles that were causing gingerbread styles to appear.

Updated toolbars to unify iOS and Android formatting toolbars, ref #323

…dpress-mobile/WordPress-Android into feature/posting-improvements

… that the scroll position is correct when in full screen.

…nd finish the EditPostActivity

* Replaced the relative layout used for the formatting toolbar with a linear layout for performance reasons. * Made the link chooser activity show the soft keyboard at launch.

…ments Feature/posting improvements

b207f3f Merge pull request #406 from wordpress-mobile/issue/405-invisible-separator-html-mode 40618cc Merge pull request #407 from wordpress-mobile/sync-wpandroid d9e4113 Bumped Travis target SDK version to 16 4ed7e84 Bumped example app midSdk to 16 88fc198 Merge commit 'a4c57ecdddaac606bb9da697c055ccd3c78162e3' into sync-editor af266b4 Updating gradle plugin to 2.1.2 af4f18b Escape invisible unicode separator characters in HTML mode d62ddc3 Merge pull request #402 from wordpress-mobile/issue/401-empty-blockquote-off-new-post 5664496 Fixed removing leftover newline when clearing blockquotes on API 21+ 84bc04c Merge pull request #399 from wordpress-mobile/issue/385-autocorrect-blockquote-bug 58fb473 When removing an empty blockquote in an otherwise empty post, ensure no leftover paragraph tags are left and that the placeholder is visible again 43d673a Fixed issue of being unable to toggle off empty blockquotes at the start of posts on API19 and below 49042e7 Merge branch 'develop' into issue/385-autocorrect-blockquote-bug 9b0eb28 Merge pull request #400 from wordpress-mobile/issue/398-old-api-new-post-blockquote 94c7577 Fix #398, buggy blockquote paragraphs at start of posts (API 19 and below) 93d0b11 Fix issue with autocorrect removing blockquotes at start of post when backspacing aacd3b4 Made matching for autocorrect blockquote fix stricter 30b54bf Fix bug where autocorrect can toggle blockquote off at the start of posts 5bfd024 Correct extra break tag sometimes added in blockquotes by autocorrect 054448f Merge branch 'hotfix/5.4.1' into release/5.5 88c040e Merge commit '0e7e33bb330aea12fc3845d1c95b483845e63c6a' into hotfix/5.4.1 e116f48 Merge pull request #4165 from wordpress-mobile/issue/4147-translated-original-size 9d0a8bf Merge commit 'e8a087f9fc25fa4e0dea63715bdd1a05e92f7db0' into hotfix/5.4.1 0aec1e3 Merge branch 'hotfix/5.4.1' into issue/4147-translated-original-size c801408 fix an issue with initial max width value in legacy image settings c3798b5 Update to latest utils version fbb73ab use MediaUtils.getImageWidthSettingFromString instead of referring to 'Original Size' a22d95f Merge pull request #4161 from wordpress-mobile/issue/391editor-fix-legacy-image-settings 5032dde Merge commit '961a76c0bc931c3a484640f9fb1e3d6f7877857b' into hotfix/5.4.1 e37555f associate the mediafile with newly created image span 613c9ce Don't attempt to remove image selection formatting if the image is no longer attached to the document e8ff0d8 On API 19 and below, don't set focus on the container when showing the edit overlay 7d03ec2 When applying the edit image overlay, give focus to the edit container instead of the image dfed869 Merge branch 'release/5.4' into release/5.5 e98a21f check for null parameters in createWPEditImageSpanRemote 939948e fix #4137: check if context and media file is null 3f9f44e Merge branch 'release/5.4' into develop 6561baa Merge commit '5da21eda6aa762a51acc7f29263ea5b6e42b3cd2' into release/5.4 09c3838 Merge branch 'release/5.4' into develop 751e919 Block media button if action in progress 3bea532 fix editor tests 9fcf821 Don't allow publishing if insert image or insert video action in progress 021572c fix wordpress-mobile/WordPress-Editor-Android#294: Block HTML mode until insert image or video has finished 95dea3f Merge pull request #4121 from wordpress-mobile/issue/294editor-block-switch-to-html-mode-until-insert-image-finished 8edbac6 Merge branch 'release/5.4' into develop 32b150c Block media button if action in progress fabde1c bump minSdkVersion from 14 to 16 c6f0c2a remove specific code for API < 16 in editor a64e81f fix editor tests 45f2000 Don't allow publishing if insert image or insert video action in progress d060f82 fix wordpress-mobile/WordPress-Editor-Android#294: Block HTML mode until insert image or video has finished dc40200 chmod 644 image files 8d6f9f1 Merge commit '3418d3e2da66bf5ecc19b5e073794c866711e776' into develop e334198 Merge pull request #3856 from wordpress-mobile/issue/3791-support-library-23.2 6448d26 Updating to support library 23.4.0 178aa19 Merge branch 'develop' into issue/3791-support-library-23.2 6ae6ec3 Improved error message displayed when failing to load visual editor HTML b7a48b3 Merge branch 'develop' into feature/magic-link efe90e8 Merge branch 'develop' into feature/magic-link f9ef8f5 Merge branch 'develop' into feature/magic-link ad37b12 Merge branch 'develop' into feature/magic-link 639a45b Merge branch 'develop' into feature/magic-link 57fc6b4 Merge branch 'develop' into feature/magic-link 61a180a Adding MissingPrefix ignore rule to Editor as well 6981157 Merge branch 'develop' into issue/3791-support-library-23.2 52f96bc Button is no longer screen width and extracting string resource 0039a31 Updating support library to 23.3.0 893b509 Updating to gradle 2.0 28ec9a8 Merge branch 'develop' into issue/3791-support-library-23.2 a28cf69 Updating build.gradle to latest rc3 1b9d708 Merge branch 'develop' into issue/3791-support-library-23.2 dabacd6 Updating the rest of the modules to buildToolsVersion 23.0.3 4b40e3f Merge branch 'develop' into issue/3791-support-library-23.2 ae9e36d Converting all android:src to app:srcCompat to handle VectorDrawables 2fa6196 Changing all Activity classes to AppCompatActivity to handle vector drawables 49304a0 Merge branch 'develop' into issue/3791-support-library-23.2 b28d697 Merge branch 'develop' into issue/3791-support-library-23.2 ada1d86 Updating support library to 23.2.1 git-subtree-dir: libs/editor git-subtree-split: b207f3f831a674d28add9b391c0d55559a9d8be6

roundhill added 30 commits November 19, 2013 09:35

Use software layerType for post content area. Fixes text overlap issue …

52d9658

…#46.

Added increased line spacing in post content area. Fixes #304. Also i…

c0a3391

…ncreased size of title EditText font to differentiate it more.

Also set text selection end, if it is valid. Fixes #324.

d072b06

Post editor switched to tabbed interface. New fragments for editing p…

58c948d

…ost content, settings and preview.

Reorganized the post settings fragment layout. Mostly a de-uglification.

053cc81

Cleaned up lint warnings in EditPostContentFragment.

1a69250

Sharing intent fixes

db28c9e

Simplified code that was checking span styles after the user typed. J…

05bdade

…ust loop through all spans instead of checking for each individual class.

Optimized the ‘formatBtnClick’ method (renamed it too!) to use way fa…

eabcc6c

…r less code but accomplish the same task.

Comment fix.

b7c2e40

Editor changes:

07413a6

* ActionBar now hides when full screen editing. * Dismissing soft keyboard when full screen editing will dismiss the full screen editor. * Animation improvements.

Merge branch 'develop' into feature/posting-improvements

5187c91

Conflicts: res/values/strings.xml src/org/wordpress/android/ui/posts/PostsListFragment.java

Remove now unused action bar layout.

a006173

Pass correct context to getPostFormatsTask(). Fixes force close.

6198f9a

Fixed some warnings and code formatting in EditPostSettingsFragment

a6db771

Tab text color fix

162286b

Fixed initLocation() force close by passing fragment root view to met…

d65a4da

…hod.

More reliable method for detecting when the soft keyboard dismisses.

3dbabc6

* Added basic post preview fragment to post editor.

7c6757e

* Removed all extra instances of the post object. Instead, fragments will use use getPost() from the main activity. * Use an onTouch listener for determining when to go to full screen editing mode.

Cleaned up some code in EditPostContentFragment, fixed constant refer…

90233bb

…ence.

Fixed quick video/photo field from not being set.

95043eb

Launch the media picker when creating a new gallery from a post. Fixes …

d9537bc

…#232.

Fixed an issue where the cancel prompt would appear early if the soft…

ef540be

… keyboard was not showing.

Update the mOriginalViewBottom value when the device rotates.

abc06bb

Merge branch 'develop' into feature/posting-improvements

02f263f

Conflicts: src/org/wordpress/android/ui/posts/PostsActivity.java src/org/wordpress/android/ui/posts/PostsListFragment.java

Moved mixpanel stats calls in to new edit post fragments.

1481c93

Merge branch 'develop' into feature/posting-improvements

07408d8

Restored autosave functionality

b8d4181

Fixed issue where selecting images from G+ photos was not working.

Removed tabs from post editor.

689afa9

* Added Post Settings button that shows at bottom of post content fragment. * Post preview button added to ActionBar * Added fade animation when entering and leaving full screen editor so it is less jarring.

Formatting toolbar improvements:

069b6db

* Made toggle buttons a minimum dp size to be easily tappable. * No more gradients and rounded corners :)

roundhill added 5 commits December 4, 2013 11:26

Merge branch 'develop' into feature/posting-improvements

eb8d3bd

Conflicts: res/values/strings.xml

Renamed NewEditPostActivity, fixed f/c when using edit button in Post…

5d88bc1

…Preview.

Cleaned up some unused code and added toast message when downloading …

bfbd508

…external image.

Adding patch from #280 that fixes save prompt even when no changes we…

dd41e50

…re made. Props @ShiftLeftLogical.

* Media can now be selected from apps/sources outside of the local a…

f3154b0

…ndroid gallery (like Dropbox). * Fixed posts list from not refreshing after saving a draft.

roundhill and others added 14 commits December 5, 2013 11:30

Don’t convert the post images to <img> tags when saving the post for …

3491153

…the post preview.

Enter full screen editor when ‘Next’ button is pressed while editing …

6ddf1fd

…the Title field. Fixes #404.

Reordered post settings items to have more frequently used settings a…

afe8e28

…t the top. Also removed some unnecessary styles that were causing gingerbread styles to appear.

Formatting toolbar icons

dc601a8

Updated toolbars to unify iOS and Android formatting toolbars, ref #323

Use holo light dialog theme for devices > v11.

12c724c

Merge branch 'feature/posting-improvements' of https://github.com/wor…

b93f8ff

…dpress-mobile/WordPress-Android into feature/posting-improvements

Set title EditText’s visibility to GONE when the animation starts, so…

439c8d0

… that the scroll position is correct when in full screen.

If user is using quick photo/video and cancels, delete the new post a…

d334f99

…nd finish the EditPostActivity

* Placed new icons from @isaackeyet in the formatting toolbar.

531ea8f

* Replaced the relative layout used for the formatting toolbar with a linear layout for performance reasons. * Made the link chooser activity show the soft keyboard at launch.

Cleaned up some compiler warnings.

909aeb2

Show the soft keyboard after adding media.

3330f40

Merge branch 'develop' into feature/posting-improvements

9ceec5d

Set time format based on device settings. Props @nbradbury

af23bba

nbradbury added a commit that referenced this pull request Dec 6, 2013

Merge pull request #399 from wordpress-mobile/feature/posting-improve…

a657de7

…ments Feature/posting improvements

nbradbury merged commit a657de7 into develop Dec 6, 2013

nbradbury deleted the feature/posting-improvements branch December 6, 2013 22:30

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Feature/posting improvements #399

Feature/posting improvements #399

Uh oh!

roundhill commented Dec 4, 2013

Uh oh!

nbradbury commented Dec 5, 2013

Uh oh!

roundhill commented Dec 5, 2013

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Feature/posting improvements #399

Feature/posting improvements #399

Uh oh!

Conversation

roundhill commented Dec 4, 2013

Uh oh!

nbradbury commented Dec 5, 2013

Uh oh!

roundhill commented Dec 5, 2013

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants