Refactoring People Management UI to use Fragments #3970
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,51 @@ | ||
| package org.wordpress.android.ui; | ||
|
|
||
| import android.content.Context; | ||
| import android.util.AttributeSet; | ||
| import android.view.ViewTreeObserver; | ||
| import android.widget.RelativeLayout; | ||
|
|
||
| public class SlidingRelativeLayout extends RelativeLayout { | ||
|
|
||
| private float mXFraction = 0; | ||
|
|
||
| public SlidingRelativeLayout(Context context) { | ||
| super(context); | ||
| } | ||
|
|
||
| public SlidingRelativeLayout(Context context, AttributeSet attrs) { | ||
| super(context, attrs); | ||
| } | ||
|
|
||
| private ViewTreeObserver.OnPreDrawListener mPreDrawListener = null; | ||
|
|
||
| // This property is used by the objectAnimator for Fragment slide animations. ex: `fragment_slide_in_from_right.xml` | ||
| @SuppressWarnings("UnusedDeclaration") | ||
| public float getXFraction() { | ||
| return mXFraction; | ||
| } | ||
|
|
||
| // This implementation fixes the first frame not being translated: http://trickyandroid.com/fragments-translate-animation/ | ||
| @SuppressWarnings("UnusedDeclaration") | ||
| public void setXFraction(float fraction) { | ||
| mXFraction = fraction; | ||
|
|
||
| if (getWidth() == 0) { | ||
| if (mPreDrawListener == null) { | ||
| mPreDrawListener = new ViewTreeObserver.OnPreDrawListener() { | ||
| @Override | ||
| public boolean onPreDraw() { | ||
| getViewTreeObserver().removeOnPreDrawListener(mPreDrawListener); | ||
| setXFraction(mXFraction); | ||
| return true; | ||
| } | ||
| }; | ||
| getViewTreeObserver().addOnPreDrawListener(mPreDrawListener); | ||
| } | ||
| return; | ||
| } | ||
|
|
||
| float translationX = getWidth() * fraction; | ||
| setTranslationX(translationX); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,107 @@ | ||
| package org.wordpress.android.ui.people; | ||
|
|
||
| import android.app.Activity; | ||
| import android.app.ListFragment; | ||
| import android.content.Context; | ||
| import android.os.Bundle; | ||
| import android.view.LayoutInflater; | ||
| import android.view.View; | ||
| import android.view.ViewGroup; | ||
| import android.widget.AdapterView; | ||
| import android.widget.AdapterView.OnItemClickListener; | ||
|
|
||
| import org.wordpress.android.R; | ||
| import org.wordpress.android.datasets.PeopleTable; | ||
| import org.wordpress.android.models.Person; | ||
|
|
||
| import java.util.List; | ||
|
|
||
| public class PeopleListFragment extends ListFragment implements OnItemClickListener { | ||
| private static String ARG_LOCAL_TABLE_BLOG_ID = "local_table_blog_id"; | ||
|
|
||
| private int mLocalTableBlogID; | ||
| private OnPersonSelectedListener mListener; | ||
|
|
||
| public static PeopleListFragment newInstance(int localTableBlogID) { | ||
| PeopleListFragment peopleListFragment = new PeopleListFragment(); | ||
| Bundle bundle = new Bundle(); | ||
| bundle.putInt(ARG_LOCAL_TABLE_BLOG_ID, localTableBlogID); | ||
| peopleListFragment.setArguments(bundle); | ||
| return peopleListFragment; | ||
| } | ||
|
|
||
| @Override | ||
| public void onAttach(Context context) { | ||
| super.onAttach(context); | ||
| try { | ||
| mListener = (OnPersonSelectedListener) context; | ||
| } catch (ClassCastException e) { | ||
| throw new ClassCastException(context.toString() + " must implement OnPersonSelectedListener"); | ||
| } | ||
| } | ||
|
|
||
| // We need to override this for devices pre API 23 | ||
| @SuppressWarnings("deprecation") | ||
| @Override | ||
| public void onAttach(Activity activity) { | ||
| super.onAttach(activity); | ||
| try { | ||
| mListener = (OnPersonSelectedListener) activity; | ||
| } catch (ClassCastException e) { | ||
| throw new ClassCastException(activity.toString() + " must implement OnPersonSelectedListener"); | ||
| } | ||
| } | ||
|
|
||
| @Override | ||
| public void onDetach() { | ||
| super.onDetach(); | ||
| mListener = null; | ||
| } | ||
|
|
||
| @Override | ||
| public View onCreateView(LayoutInflater inflater, ViewGroup container, Bundle savedInstanceState) { | ||
| return inflater.inflate(R.layout.people_list_fragment, container, false); | ||
| } | ||
|
|
||
| @Override | ||
| public void onActivityCreated(Bundle savedInstanceState) { | ||
| super.onActivityCreated(savedInstanceState); | ||
|
|
||
| mLocalTableBlogID = getArguments().getInt(ARG_LOCAL_TABLE_BLOG_ID); | ||
| getListView().setOnItemClickListener(this); | ||
| } | ||
|
|
||
| @Override | ||
| public void onResume() { | ||
| super.onResume(); | ||
|
|
||
| refreshPeopleList(); | ||
| } | ||
|
|
||
| public void refreshPeopleList() { | ||
| if (!isAdded()) return; | ||
|
|
||
| List<Person> peopleList = PeopleTable.getPeople(mLocalTableBlogID); | ||
|
|
||
| PeopleAdapter peopleAdapter = (PeopleAdapter) getListAdapter(); | ||
| if (peopleAdapter == null) { | ||
| peopleAdapter = new PeopleAdapter(getActivity(), peopleList); | ||
| setListAdapter(peopleAdapter); | ||
| } else { | ||
| peopleAdapter.setPeopleList(peopleList); | ||
| } | ||
| } | ||
|
|
||
| @Override | ||
| public void onItemClick(AdapterView<?> parent, View view, int position, long id) { | ||
| if (mListener != null) { | ||
| Person person = (Person) parent.getItemAtPosition(position); | ||
| mListener.onPersonSelected(person); | ||
| } | ||
| } | ||
|
|
||
| // Container Activity must implement this interface | ||
| public interface OnPersonSelectedListener { | ||
| void onPersonSelected(Person person); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For consistency, let's define these constants with all-caps strings, like earlier in this PR (https://github.com/wordpress-mobile/WordPress-Android/pull/3970/files#diff-76558a95ecd9db2c0dda264a760a7e48R20). Cheers!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right those 2 are different, but maybe I should have used all-lowercase on the other one looking at all the other files:
https://github.com/wordpress-mobile/WordPress-Android/blob/develop/WordPress/src/main/java/org/wordpress/android/ui/prefs/AccountSettingsActivity.java#L12
https://github.com/wordpress-mobile/WordPress-Android/blob/develop/libs/editor/WordPressEditor/src/main/java/org/wordpress/android/editor/EditorFragment.java#L61-L73
https://github.com/wordpress-mobile/WordPress-Android/blob/develop/WordPress/src/main/java/org/wordpress/android/ui/prefs/AppSettingsActivity.java#L14-L15
https://github.com/wordpress-mobile/WordPress-Android/blob/develop/WordPress/src/main/java/org/wordpress/android/ui/comments/CommentsActivity.java#L38
Looking at the style guidelines we use I don't see any mention of the right side expression of constant declarations. So, maybe let's go with the rest of the app and use all lowercase instead. Sounds good?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All-lowercase is fine by me, let's go with that +1