First pass at fixing #273. #356
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It would be nice to add the reply field at the bottom of the notifications screen, without opening the web-browser, or the near to be implemented in the native reader, the AuthenticatedWebView (#175). This is probably something we can do later, when comments unification is completely done. Also, this feature is only available for a small group of lucky people, I don't think we no need to spent more time on this at the moment.
maxme
added a commit
that referenced
this pull request
Nov 25, 2013
…matcher First pass at fixing #273.
Contributor
|
Reviewed and Tested. I agree with that: I don't think we no need to spent more time on this at the moment. |
maxme
added a commit
that referenced
this pull request
Apr 21, 2016
17887d3 Merge pull request #354 from wordpress-mobile/issue/230-first-char-zw-space c5c0593 Added 'grave accent' keyCode to list of keyCodes ignored by paragraph handler 4156c10 Merge pull request #356 from wordpress-mobile/issue/353-title-html-entities e6344a1 Return plaintext for the title field in getHTMLForCallback, to avoid encoding HTML entities 4e38e7d Fixed hardcoded ZSSField name in handleKeyDownEvent f63c4fa Corrected a comment 6b1fb19 Merge branch 'develop' into issue/230-first-char-zw-space d066fbe On API 19, don't wrap the first line in paragraph tags - wait until first newline ecf7e40 s/wrappedDomNode()/getWrappedDomNode()/ 56eff9b Added editor-utils.js with some utility tag builder functions for ZSSEditor 9ec61ed Refactor ZSSEditor.resetSelectionOnField to accept an offset value for the range f4c135b Don't handle paragraph wrapping for non-printable keyCodes (hardware keyboards) git-subtree-dir: libs/editor git-subtree-split: 17887d367d19e3f94f6f0be18db334a38fa60899
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It would be nice to add the reply field at the bottom of the notifications screen, without opening the web-browser, or the near to be implemented in the native reader, the AuthenticatedWebView (#175).
This is probably something we can do later, when comments unification is completely done. Also, this feature is only available for a small group of lucky people, I don't think we no need to spent more time on this at the moment.