Fix #330: improve reader "blogs I follow" empty view #337
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
The animation is nice, but there are a few problems here:
As an aside, new users are subscribed to "WordPress.com News" & "The Daily Post" by default, so it's rare that they'd ever see this animation.
|
Contributor
Author
I don't get the auto-subscription behavior (when I create a wpcom user and go to "Blogs I follow", I see this blank page). Note: We changed that page in order to use this page as the landing page after a new wpcom user sign up. I thought we could follow blogs from here. So we should maybe redirect new users to "Freshly Pressed" instead and keep this empty view (and change the wording of course) for "Blogs I follow" and "Posts I like" and tags without articles. |
Contributor
|
I think redirecting users to "Freshly Pressed" is the right thing to do even when the user is following any blogs. The "Freshly Pressed" experience will likely be superior to "Blogs I Follow" - especially when the user is following RSS feeds, since RSS posts won't have a featured image. I'll talk with Tom about this. I created my new account via the web app, so perhaps the auto-subscribe doesn't occur when you create an account via mobile? FWIW, I like your "arrow tip" approach much more than the wordier approach. |
…hange the default empty view texts accordingly
Contributor
Author
|
I just tested, auto-subscription to "WordPress.com News" & "The Daily Post" is wpcom Web only feature. I fixed the bug, changed wording, added a tip arrow: https://cloudup.com/c1jVmOrEiwD |
…oints suffix as tag string id
Contributor
Author
|
Removed moving arrow tip (after design discussion). Rewrote tag detection using the tag endpoint to extract a string id (only works for default tags). Needs another review on this: 838c677...795d80b |
Contributor
|
Code looks good, merging. |
nbradbury
added a commit
that referenced
this pull request
Nov 25, 2013
…r-empty-list Fix #330: improve reader "blogs I follow" empty view
maxme
added a commit
that referenced
this pull request
Apr 8, 2016
41a1010 Merge pull request #337 from wordpress-mobile/issue/336-media-insert-paragraph-fix 767f36f Added comment for API<19 media insertion newline hack 1678bd1 Updating to gradle 2.0 c7a583d Fixed adding newline after media insertion for API<19 2e12295 Corrected some variable names in media insertion methods 200c8d5 Modified paragraph tag wrapping for media insertion to handle div tags correctly 94aa080 Updating to rc3 19cfc2e Merge commit 'c5b98a88c01551e8dbf44366072607d364ec01dd' into develop 64a065f Updating the rest of the modules to buildToolsVersion 23.0.3 f2c8351 Merge commit '4c9324cf1eee00b66c76e0d5a917c86e1293a845' into develop 3878f51 Add missing classes for images inserted from media library - also fix a bug with undefined alt text 3a4fe83 Add missing attributes for uploaded images 61f219e update to android-gradle-2.0.0-rc1 29e1264 Merge commit 'c6efe0a9190244d40e64300efc9cca56ae5acd5c' into develop a061001 Merge branch 'develop' into issue/120editor-initial-focus 0aa44f3 Merge commit '9b0b5fab24db9f435b278ad0b9e77d5895135700' into develop 0e8a35f Merge pull request #3897 from wordpress-mobile/issue/260editor-clear-failed-images-on-upload 85e19fb Null check getParentRangeOfFocusedNode/setRange in onMutationObserved - in case editor is not in focus 778bc7a Show the software keyboard once the DOM has loaded e0b6c72 Focus on the title field when opening posts 58c156b New EditorFragment method to removeAllFailedMediaUploads() 533abee New JS function ZSSEditor.removeAllFailedMediaUploads 29db13e Merge pull request #3896 from wordpress-mobile/issue/300editor-broken-images-after-upload-2 c53cb9d remove debug logs a29070e Use remoteurl in the link wrapper 9abfb9d Merge branch 'develop' into issue/300editor-broken-images-after-upload-2 964938e Merge branch 'develop' into issue/297editor-backspace-media f6acb17 update to com.android.tools.build:gradle:2.0.0-beta7 e71320e Merge branch 'develop' into issue/297editor-backspace-media 2ff37a5 Merge commit '8db246f15ce6f4d2c7f7f7ec51c68b87e9a66c2f' into develop 7c57f6f Changed MutationObserver handling to check if the WebView supports it, rather than rely on API levels 256916c Refactor: grouped mutation observation methods together c129a3b Refactored DOM element mutation listening, delegating everything to one trackNodeForMutation method 3df3bbd Changed MutationObserver behavior to track individual media nodes instead of each contenteditable div f096312 Moved failed media methods to the generic media method group b13515d Parse for failed media when returning from HTML to visual mode f193d88 Track DOMNodeRemoved events when parsing for failed media 44b4e92 Fixed a variable name error in ZSSEditor.removeImage b2342da On API<19, use DOMNodeRemoved events to track media deletions (instead of the unsupported MutationObserver used for newer APIs) e5e7693 Merge branch 'develop' into issue/297editor-backspace-media 06b252d Merge pull request #3804 from wordpress-mobile/issue/enable-editor-debug-mode 2daf87e Consume KEYCODE_VOLUME_UP event when debug print is called 8519f0d broken retries 8bd6476 Merge branch 'issue/enable-editor-debug-mode' into issue/300editor-broken-images-after-upload-2 06d70f9 use a remoteUrl attribute to avoid seeing broken image if download failed e5c9d8a remove debug action bar button and log raw html when volume up button is pressed 19f7043 fix function call errors dae02b2 Add back image swapping onError 515e508 fix wordpress-mobile/WordPress-Editor-Android#300: Retry download onError after an upload 05936de add missing comment 316f566 Updated gradle to 2.0.0-beta6 d6871e8 Fixes an issue where manually deleting uploading/failed media will cause the caret to disappear eb05458 Notify native through a callback whenever uploading/failed media are manually deleted 4fe64ad catch a common JS exception 3d45aff Merge branch 'develop' into issue/288editor-log-js-errors-in-crashlytics 8db4d8c fix wordpress-mobile/WordPress-Editor-Android#288: new EditorWebViewAbstract.ErrorListener used to forward JS errors to Crashlytics f2ba93d Keep the format bar disabled on rotation when the title field is in focus f2f6c0f Rely on ZSSEditor to flag uploads as completed in native-side checks 1fc3ed1 Added null checking for MediaType onMediaUploadFailed 223c7f0 Wait until the ZSSEditor has replaced the local media with remote before marking it as completed 4ff61f7 Strip any trailing when returning the title git-subtree-dir: libs/editor git-subtree-split: 41a1010939cb0af0cc43672558265000623aefd2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #330 - improve empty view + box animation
https://cloudup.com/csBoyPM9Phg