Team Management UI #3364
Merged
Team Management UI #3364
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A mock method is also introduced to get a person from the DB for the local table id. For now, it'll return mock person object to test the UI.
We have decided not to merge the current branch with develop, so there is no reason to hide the People link anymore.
Contributor
There was a problem hiding this comment.
I know it's only a stub method but we should not add anything to WordPressDB. Please create a "PersonTable" class and put all db related method there.
Contributor
|
Looks good, I've some design comments but obviously too early to post them. |
Contributor
Author
|
@maxme I've added the |
Contributor
|
|
to
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds most of the Team Management UI for #3286. There are a few stub methods and I am using test data to test the UI. Since this feature is going to be large, we want to merge it to a temporary branch once in a while so the review is easier. I'll also need to switch to work on Me page since it's more urgent and we don't want this branch to go stale without any reviews done on it.
In the PR, I basically added a people page which will eventually show the users in that particular site. I've also added the person detail page which will be accessible once you select a user from the list. You can find screenshots of the current screen below.