Feature/2886 general site settings #2979

tonyr59h · 2015-07-15T23:42:09Z

Moved from #2971

Added attribute to set number of values on SeekBarPreference. Moved Summary updates to the fragment.

Adding class to handle limiting the summary size for certain preferences. Converting language codes for list preference values.

…ies.

nbradbury · 2015-07-16T12:31:40Z

I'm still seeing a couple of crashes:

When the device is in airplane mode, tapping "Settings" crashes the app
Rotating the device while settings is showing crashes the app

nbradbury · 2015-07-16T12:32:40Z

WordPress/src/main/java/org/wordpress/android/ui/prefs/SiteSettingsFragment.java

It would be more bandwidth-friendly to only call applyChanges() when the user has actually made changes.

applyChanges()makes sure there are changes by checking the params generated by 'generatePostParams()' before making a POST request.

nbradbury · 2015-07-16T12:40:07Z

Just noticed that changes to the language preference aren't being retained.

nbradbury · 2015-08-05T17:11:29Z

The radio buttons on the privacy settings dialog should be mutually exclusive, but right now I can check all three of them.

nbradbury · 2015-08-05T17:20:11Z

When returning from settings, changes to the site title aren't reflected on the My Site fragment or the site picker
The detail text on the privacy and language dialogs is too light
Site title & tagline still show HTML entities such as '
If I select a language from the language dialog then hit cancel, the language still gets changed
It feels odd to have the address appear disabled in the middle of settings. A static label at the top/bottom would make more sense.
The soft keyboard needs to be hidden after changing the title or tagline

…-site-settings Conflicts: WordPress/src/main/res/values/strings.xml

nbradbury · 2015-08-23T12:20:03Z

This is shaping up nicely and looks great, but there are a few minor issues still:

Probably not a big deal, but if you rotate the device while either the privacy dialog or language dialog is showing, the dialog disappears
If the connection is lost while settings are showing, any changes are silently lost after closing settings
As mentioned in a previous review, if you change the blog name the old name continues to appear on the My Site page and site picker
HTML entities are still appearing the the title and tagline:

…-site-settings

nbradbury · 2015-08-25T13:38:08Z

Just got the latest commits and had this weird problem occur: I edited the site title, returned to the My Site page, then after a second or two the title disappeared.

nbradbury · 2015-08-26T20:44:12Z

Looks good

…ite-settings Feature/2886 general site settings

tonyr59h added 20 commits June 23, 2015 18:06

General section if Site Settings added. Using REST API to pull site info

64536a3

Updating API interface to access title field.

02c99d7

Smoothing SeekBarPreferenceAnimation and clamping.

03a4ee9

Updating Title, Tagline, and Visibility after prompting user to sync.

90f6fb0

Replaced alert dialog with a Save menu option to save changes.

a39a4b8

Notifying of changes to SeekBarPreference value.

6613fa8

SeekBarPreference can handle arbitrary number of discrete points.

7db4e62

Added attribute to set number of values on SeekBarPreference. Moved Summary updates to the fragment.

Merge branch 'develop' into feature/2886-general-site-settings

c192c59

Adding remaining preferences, updating design.

6f0d04a

Adding class to handle limiting the summary size for certain preferences. Converting language codes for list preference values.

Removing unused Preferences.

e5abc59

Merge branch 'develop' into feature/2886-general-site-settings

a89a9be

Saving only changed settings, using resources for language.

9e928a0

Updating ActionBar title. Save button is now Undo.

1b21ba4

Disabling Address field until it's implemented. Fixing initial summar…

c41a8a1

…ies.

Merge branch 'develop' into feature/2886-general-site-settings

731c899

Removing unused layout.

1b142d9

Addressing code review. Closing Activity on settings fetch error.

f3c555f

Fixing build!

4df1aed

Removing Undo button.

08712ef

Merge branch 'develop' into feature/2886-general-site-settings

0f5f8e5

tonyr59h added the Site Settings label Jul 15, 2015

tonyr59h added this to the 4.5 milestone Jul 15, 2015

nbradbury self-assigned this Jul 16, 2015

nbradbury reviewed Jul 16, 2015
View reviewed changes

tonyr59h added 4 commits July 19, 2015 23:30

Removing unused undoChanges method.

a6ef9ca

Toasting and leaving Settings if no network is available.

ef4b29b

Moving preference initialization to onResume to avoid crash.

ef633c6

Merge branch 'develop' into feature/2886-general-site-settings

79f4dd4

tonyr59h added 11 commits August 6, 2015 11:14

Using string resource and fixing typo.

e230cc3

Adding shadow to Settings action bar with recommended 4dp elevation.

03b6d03

Fixing radio button issue on privacy preference.

39f08ff

Styling the AlertDialog to better match mock-ups.

ee1a307

Styling preference screen based on mock-ups.

be8c146

Merge branch 'feature/site-settings-review' into feature/2886-general…

74e516c

…-site-settings Conflicts: WordPress/src/main/res/values/strings.xml

More design improvements. Dividers as expected in the preference list.

fff72f6

Using correct font for preference category headers.

3b18601

Using custom Action Bar layout to use OpenSans

ec2490f

Fixing size

f48b6f8

Finishing touches on styling.

879ca78

tonyr59h modified the milestones: 4.6, 4.5 Aug 18, 2015

tonyr59h added 2 commits August 20, 2015 18:05

Adjusting fonts

6ad00d6

Fixing list preference cancel bug.

fe9346e

tonyr59h added 6 commits August 24, 2015 11:34

Disabling Settings editing when connection is lost.

47c9bf0

Updating MySiteFragment view when blog name is changed.

5a72a63

Replacing HTML entities and updating blog with self-hosted title changes

4dd5f54

Keyboard hidden when dialog dismissed, cursor placed at end of text.

cf8b955

Merge branch 'feature/site-settings-review' into feature/2886-general…

9a27aec

…-site-settings

Fixing incorrect dialog text and some HTML entity issues

bfeb69a

Fixing self-hosted title change bug and handling empty title change.

24d9181

nbradbury added a commit that referenced this pull request Aug 26, 2015

Merge pull request #2979 from wordpress-mobile/feature/2886-general-s…

f0fee90

…ite-settings Feature/2886 general site settings

nbradbury merged commit f0fee90 into feature/site-settings-review Aug 26, 2015

nbradbury deleted the feature/2886-general-site-settings branch August 26, 2015 20:46

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Feature/2886 general site settings #2979

Feature/2886 general site settings #2979

Uh oh!

tonyr59h commented Jul 15, 2015

Uh oh!

nbradbury commented Jul 16, 2015

Uh oh!

nbradbury Jul 16, 2015

Uh oh!

tonyr59h Jul 20, 2015

Uh oh!

nbradbury commented Jul 16, 2015

Uh oh!

nbradbury commented Aug 5, 2015

Uh oh!

nbradbury commented Aug 5, 2015

Uh oh!

nbradbury commented Aug 23, 2015

Uh oh!

nbradbury commented Aug 25, 2015

Uh oh!

nbradbury commented Aug 26, 2015

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Feature/2886 general site settings #2979

Feature/2886 general site settings #2979

Uh oh!

Conversation

tonyr59h commented Jul 15, 2015

Uh oh!

nbradbury commented Jul 16, 2015

Uh oh!

nbradbury Jul 16, 2015

Choose a reason for hiding this comment

Uh oh!

tonyr59h Jul 20, 2015

Choose a reason for hiding this comment

Uh oh!

nbradbury commented Jul 16, 2015

Uh oh!

nbradbury commented Aug 5, 2015

Uh oh!

nbradbury commented Aug 5, 2015

Uh oh!

nbradbury commented Aug 23, 2015

Uh oh!

nbradbury commented Aug 25, 2015

Uh oh!

nbradbury commented Aug 26, 2015

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants