Repository navigation
Conversation
RELEASE-NOTES.txt was maintained by the code_freeze lane, which seeded the per-version Play Store notes from it. Remove the file along with everything that reads, writes, or documents it. Changes: - Delete RELEASE-NOTES.txt and its merge=union rule in .gitattributes - Drop the extract and new-section steps from code_freeze, along with the Jetpack copy and reminder that depended on them - Remove RELEASE_NOTES_SOURCE_PATH from the Fastfile - Remove the Danger message for changes to the file - Remove the Release Notes Compilation Process section from CLAUDE.md
Releases go through the trunk internal build and the beta and production promotion lanes. Remove the release-branch lanes, the pipelines that ran them, and the per-version Play Store release notes they maintained. Changes: - Delete fastlane/lanes/release.rb: code freeze, beta, hotfix, finalize and publish lanes, create_gh_release, and their helpers - Remove build_and_upload_release, build_and_upload_pre_releases, build_beta and download_signed_apks_from_google_play from build.rb - Remove update_appstore_strings, and the per-version release note keys from generate_playstore_strings and download_metadata_strings - Delete the Buildkite pipelines and command scripts for those lanes - Delete the per-version release_notes.txt and release_notes_short.txt sources for both apps, and the Danger check that watched them - Remove the version helpers only those lanes used - Move get_app_name_option! and validate_app_name! to the Fastfile, and bundle_file_path and signed_apk_path to build.rb - Describe the screenshot copy translation steps with the remaining lanes
Release notes are attached when a build is promoted to beta, so the per-version changelogs uploaded with each internal build are unused. Changes: - Skip changelog upload in upload_build_to_play_store - Delete the changelogs/default.txt files for both apps
Collaborator
Generated by 🚫 Danger |
fastlane/lanes/release.rb was the only file excluded from Lint/EmptyBlock and Style/MultilineBlockChain, and it no longer exists. Changes: - Remove both cop entries from .rubocop_todo.yml
Changes: - Reflow the mac-metal comment in download-translations.yml - Remove the blank line at the end of CLAUDE.md
generate_playstore_strings starts with ensure_git_status_clean, so it
fails while the updated screenshot_{n}.txt files are uncommitted.
Changes:
- Add a step to commit the .txt changes before running the lane
Contributor
|
|
Contributor
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
Now that we have been using weekly automated releases for a while, this PR removes the old release flow that was based on code-freeze approach with
release/x.ybranches.Description
Releases go through the trunk internal build and the beta and production promotion lanes. This removes the release-branch flow that preceded them: its lanes, the Buildkite pipelines that ran them, and the release notes files only it maintained.
Removed
fastlane/lanes/release.rb:code_freeze,complete_code_freeze,new_beta_release,new_hotfix_release,finalize_hotfix_release,finalize_release,publish_release,check_translations_coverage,trigger_beta_build,trigger_release_build,create_gh_release, and the helpers only they used (backmerge PR, milestones, release branch deletion)build.rb:build_and_upload_release,build_and_upload_pre_releases,build_beta,download_signed_apks_from_google_playlocalization.rb:update_appstore_strings, plus the per-versionrelease_notekeys ingenerate_playstore_stringsanddownload_metadata_stringscode-freeze.yml,complete-code-freeze.yml,new-beta-release.yml,new-hotfix-release.yml,finalize-release.yml,finalize-hotfix-release.yml,publish-release.yml,update-release-notes.yml,beta-builds.yml,release-builds.yml) and their command scriptsRELEASE-NOTES.txtand its.gitattributesrulerelease_notes.txtandrelease_notes_short.txtfor both apps, and thechangelogs/default.txtfiles generated from themCLAUDE.mdKept or moved
get_app_name_option!andvalidate_app_name!move to theFastfile;bundle_file_pathandsigned_apk_pathmove tobuild.rblocalize_librariesandupdate_frozen_strings_for_translationstay, unchangedChanged
upload_build_to_play_storeno longer uploads changelogs. Its only caller is the trunk internal build; release notes are attached when a build is promoted to beta.PlayStoreStrings.pofor both apps is regenerated withgenerate_playstore_strings, which dropsrelease_note_269and adds the translator comment torelease_note_static_serious.fastlane/screenshots/README.mddescribes the screenshot copy translation steps withgenerate_playstore_stringsanddownload_metadata_strings.Testing instructions
No manual testing. Other than the changelog upload above, the lanes used by the trunk internal build, beta and production promotion, rollout, and translation sync are unchanged, and none of the removed lanes or pipelines are referenced by them or by a Buildkite schedule.