Repository navigation
Explain sign-in failures caused by a blocked Authorization header - #23383
Draft
crazytonyli wants to merge 3 commits into
Draft
crazytonyli wants to merge 3 commits into
crazytonyli wants to merge 3 commits into
Conversation
Temporary pin to the build published by Automattic/wordpress-rs#1659. Replace it with a release once one includes verifyIssuedApplicationPassword.
After a site issues an application password, the app checks it before storing anything. If WordPress reports that it received no credentials, the login stops and a dialog tells the user to contact their host and names the Site Health check. The dialog survives activity recreation. Any other failure of the check is logged and the login continues as before.
Collaborator
Generated by 🚫 Danger |
Contributor
Project dependencies changeslist! Upgraded Dependencies
rs.wordpress.api:android:1659-4e11c39c892f99c3e8850ae1ce8c7a07eec58187, (changed from 0.9.0)
rs.wordpress.api:kotlin:1659-4e11c39c892f99c3e8850ae1ce8c7a07eec58187, (changed from 0.9.0)tree +--- project :libs:fluxc
-| \--- rs.wordpress.api:android:0.9.0
-| +--- com.squareup.okhttp3:okhttp:5.4.0 (*)
-| +--- com.squareup.okhttp3:okhttp-tls:5.4.0
-| | +--- org.jetbrains.kotlin:kotlin-stdlib:2.1.21 -> 2.4.20 (*)
-| | +--- com.squareup.okio:okio:3.17.0 (*)
-| | \--- com.squareup.okhttp3:okhttp:5.4.0 (*)
-| +--- net.java.dev.jna:jna:5.19.1
-| +--- rs.wordpress.api:kotlin:0.9.0
-| | +--- com.squareup.okhttp3:okhttp:5.4.0 (*)
-| | +--- com.squareup.okhttp3:okhttp-tls:5.4.0 (*)
-| | +--- org.jetbrains.kotlinx:kotlinx-coroutines-core:1.10.2 -> 1.11.0 (*)
-| | \--- org.jetbrains.kotlin:kotlin-stdlib:2.3.21 -> 2.4.20 (*)
-| \--- org.jetbrains.kotlin:kotlin-stdlib:2.3.21 -> 2.4.20 (*)
+| \--- rs.wordpress.api:android:1659-4e11c39c892f99c3e8850ae1ce8c7a07eec58187
+| +--- com.squareup.okhttp3:okhttp:5.4.0 (*)
+| +--- com.squareup.okhttp3:okhttp-tls:5.4.0
+| | +--- org.jetbrains.kotlin:kotlin-stdlib:2.1.21 -> 2.4.20 (*)
+| | +--- com.squareup.okio:okio:3.17.0 (*)
+| | \--- com.squareup.okhttp3:okhttp:5.4.0 (*)
+| +--- net.java.dev.jna:jna:5.19.1
+| +--- rs.wordpress.api:kotlin:1659-4e11c39c892f99c3e8850ae1ce8c7a07eec58187
+| | +--- com.squareup.okhttp3:okhttp:5.4.0 (*)
+| | +--- com.squareup.okhttp3:okhttp-tls:5.4.0 (*)
+| | +--- org.jetbrains.kotlinx:kotlinx-coroutines-core:1.10.2 -> 1.11.0 (*)
+| | \--- org.jetbrains.kotlin:kotlin-stdlib:2.3.21 -> 2.4.20 (*)
+| \--- org.jetbrains.kotlin:kotlin-stdlib:2.3.21 -> 2.4.20 (*)
-\--- rs.wordpress.api:android:0.9.0 (*)
+\--- rs.wordpress.api:android:1659-4e11c39c892f99c3e8850ae1ce8c7a07eec58187 (*) |
1 task done
Contributor
|
|
Contributor
|
|
Contributor
🤖 Build Failure AnalysisThis build has failures. Claude has analyzed them - check the build annotations for details. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Temporarily uses the wordpress-rs build from Automattic/wordpress-rs#1659.
Description
Some hosts strip the Authorization header, leaving newly issued application passwords unusable.
Check new passwords before saving them. When the header is blocked, stop sign-in and show a dialog explaining the problem and directing users to their hosting provider. This covers browser sign-in and both application-password creation prompts. Other verification errors preserve the existing flow.
Testing instructions
Blocked header:
Existing sites: