Open
Conversation
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Collaborator
Generated by 🚫 Danger |
Contributor
|
|
Contributor
|
|
The debug source set's icon drawables (WordPress icons) were overriding the jetpack source set's drawables due to Android's resource merge priority (build type > product flavor), causing jetpackDebug to show the WordPress icon instead of the Jetpack icon. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
nbradbury
changed the title
…-Android into issue/debug-build-variant-titles
Contributor
|
What do you think about using the debug icon we used to have? It would avoid confusion since right now I see the same icon we use in prod |
Restore the adaptive icon drawables (green background with lime Jetpack bolt) that were deleted in #22651 when jetpackJalapeno was renamed to jetpackDebug. This gives the debug build a visually distinct icon from the release build. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
Contributor
Author
Yep, I should've done that to start with. Fixed in 9bc9bf6. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Testing instructions
Verify Jetpack debug app title and icon:
jetpackDebugvariantVerify WordPress debug app title and icon:
wordpressDebugvariant