Fix: Add ProGuard rules for jsoup's optional RE2J dependency to fix release build

[adalpari]

Description

See the build issue: https://buildkite.com/automattic/wordpress-android/builds/24599

Fixes the beta release build failure caused by R8 detecting missing com.google.re2j classes referenced by jsoup's optional RE2J
regex support.

jsoup 1.22.1 added optional support for Google's RE2J regex engine for CSS selectors. Since RE2J is not included as a dependency in
this project, R8 fails the release build when it encounters references to the missing classes.

The fix adds -dontwarn rules to proguard.cfg to suppress these warnings, which is the standard approach for optional dependencies.

Why this won't break the app

RE2J is an optional dependency in jsoup. The library is designed to:

• Detect at runtime whether RE2J is available on the classpath
• Gracefully fall back to Java's built-in regex engine if RE2J is not present

The -dontwarn rules only tell R8 not to fail the build when it sees references to classes that might not exist at runtime. They
don't change any runtime behavior.

At runtime, jsoup checks if com.google.re2j classes are available. Since they're not included in the app, jsoup automatically uses
Java's standard java.util.regex engine instead - which is what the app was using before jsoup added RE2J support.

[dangermattic]

	1 Warning
⚠️	PR is not assigned to a milestone.

Generated by 🚫 Danger

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[wpmobilebot]

📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.

	App Name	Jetpack
	Flavor	Jalapeno
	Build Type	Debug
	Version	pr22521-0732803
	Commit	0732803
	Direct Download	jetpack-prototype-build-pr22521-0732803.apk

Note: Google Login is not supported on these builds.

[wpmobilebot]

📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.

	App Name	WordPress
	Flavor	Jalapeno
	Build Type	Debug
	Version	pr22521-0732803
	Commit	0732803
	Direct Download	wordpress-prototype-build-pr22521-0732803.apk

Note: Google Login is not supported on these builds.

[adalpari]

@claude

[claude]

Claude finished @adalpari's task in 1m 21s —— View job

---

Code Review

Progress

• Read and analyze the ProGuard configuration changes
• Review for correctness and best practices
• Provide comprehensive feedback

---

Summary

The PR correctly addresses the R8 build failure by adding -dontwarn rules for jsoup's optional RE2J dependency. The implementation is clean, well-documented, and follows established patterns in the codebase.

✅ Strengths

1. Correct Approach: Using -dontwarn for optional dependencies is the standard and recommended approach for ProGuard/R8 configuration.

2. Proper Documentation: The inline comment clearly explains why these rules are needed (# jsoup has optional support for Google's RE2J regex library which is not included).

3. Consistent Formatting: The change follows the existing convention used throughout proguard.cfg:

   • Section markers with ###### jsoup - begin and ###### jsoup - end
   • Clear, descriptive comments
   • Proper spacing

4. Complete Coverage: Both RE2J classes that jsoup optionally uses are covered:

   • com.google.re2j.Matcher
   • com.google.re2j.Pattern

5. Right Location: The rules are added to WordPress/proguard.cfg, which is correctly referenced in WordPress/build.gradle:278 for release builds.

6. Safe at Runtime: As explained in the PR description, jsoup gracefully falls back to Java's standard regex when RE2J is not available, so these warnings can be safely suppressed.

📋 Observations

1. Version Context: The codebase is using jsoup 1.22.1 (gradle/libs.versions.toml:84), which introduced optional RE2J support. This confirms the need for these rules.

2. Scope: jsoup is used extensively across the codebase (15+ files), primarily for HTML parsing in posts, media processors, reader, and stats. The -dontwarn rules won't affect any of this functionality.

3. Build Configuration: ProGuard rules are applied via build.gradle:278 using proguardFiles getDefaultProguardFile('proguard-android.txt'), 'proguard.cfg', so this change will be included in release builds.

✅ Approval

This is a straightforward, correct fix for the build failure. The change:

• ✅ Solves the immediate build problem
• ✅ Uses the recommended approach for optional dependencies
• ✅ Is well-documented and follows existing conventions
• ✅ Has no impact on runtime behavior
• ✅ No security concerns
• ✅ No performance implications

Recommendation: Approve and merge.

---