CMM-1142 stats create todays card rust by adalpari · Pull Request #22502 · wordpress-mobile/WordPress-Android

adalpari · 2026-01-20T14:45:28Z

Description

Second part of #22496, this PR uses the new wordpress-rs stats endpoint to fetch today stats. NO UI CHANGES

Testing instructions

Today's Stats Card displays correctly:

Log in with a WordPress.com account that has a site with stats
Navigate to the new stats screen

Verify the card loads with graph, views, visitors, likes, and comments counts

# Conflicts: # WordPress/src/main/java/org/wordpress/android/ui/newstats/todaysstat/TodaysStatsCard.kt # WordPress/src/main/java/org/wordpress/android/ui/newstats/todaysstat/TodaysStatsViewModel.kt # WordPress/src/test/java/org/wordpress/android/ui/newstats/todaysstat/TodaysStatsViewModelTest.kt

dangermattic · 2026-01-20T14:46:12Z

	2 Warnings
⚠️	This PR is larger than 300 lines of changes. Please consider splitting it into smaller PRs for easier and faster reviews.
⚠️	PR is not assigned to a milestone.

Generated by 🚫 Danger

adalpari · 2026-01-20T14:49:00Z

gradle/libs.versions.toml

 wordpress-lint = '2.2.0'
 wordpress-persistent-edittext = '1.0.2'
-wordpress-rs = 'trunk-21200d63735de310067d88c7dfb6080a2200f18e'
+wordpress-rs = '1106-8dad0111fb97082cc2ab4280835d4e1e3167210a'


This is pointing a PR on the wp repo. But, the idea is to merge it today and point to trunk again

wpmobilebot · 2026-01-20T14:55:14Z

Project dependencies changes

list

! Upgraded Dependencies
rs.wordpress.api:android:trunk-8d78ff73bc58961adb1059ea895eb946ff29bccb, (changed from trunk-21200d63735de310067d88c7dfb6080a2200f18e)
rs.wordpress.api:kotlin:trunk-8d78ff73bc58961adb1059ea895eb946ff29bccb, (changed from trunk-21200d63735de310067d88c7dfb6080a2200f18e)

tree

 +--- project :libs:fluxc
-|    \--- rs.wordpress.api:android:trunk-21200d63735de310067d88c7dfb6080a2200f18e
-|         +--- com.squareup.okhttp3:okhttp:4.12.0 -> 5.3.2 (*)
-|         +--- com.squareup.okhttp3:okhttp-tls:4.12.0
-|         |    +--- com.squareup.okhttp3:okhttp:4.12.0 -> 5.3.2 (*)
-|         |    +--- com.squareup.okio:okio:3.6.0 -> 3.16.4 (*)
-|         |    \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.8.21 -> 1.9.24 (*)
-|         +--- net.java.dev.jna:jna:5.18.1
-|         +--- rs.wordpress.api:kotlin:trunk-21200d63735de310067d88c7dfb6080a2200f18e
-|         |    +--- com.squareup.okhttp3:okhttp:4.12.0 -> 5.3.2 (*)
-|         |    +--- com.squareup.okhttp3:okhttp-tls:4.12.0 (*)
-|         |    +--- org.jetbrains.kotlinx:kotlinx-coroutines-core:1.10.2 (*)
-|         |    \--- org.jetbrains.kotlin:kotlin-stdlib:2.1.21 -> 2.2.21 (*)
-|         \--- org.jetbrains.kotlin:kotlin-stdlib:2.1.21 -> 2.2.21 (*)
+|    \--- rs.wordpress.api:android:trunk-8d78ff73bc58961adb1059ea895eb946ff29bccb
+|         +--- com.squareup.okhttp3:okhttp:4.12.0 -> 5.3.2 (*)
+|         +--- com.squareup.okhttp3:okhttp-tls:4.12.0
+|         |    +--- com.squareup.okhttp3:okhttp:4.12.0 -> 5.3.2 (*)
+|         |    +--- com.squareup.okio:okio:3.6.0 -> 3.16.4 (*)
+|         |    \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.8.21 -> 1.9.24 (*)
+|         +--- net.java.dev.jna:jna:5.18.1
+|         +--- rs.wordpress.api:kotlin:trunk-8d78ff73bc58961adb1059ea895eb946ff29bccb
+|         |    +--- com.squareup.okhttp3:okhttp:4.12.0 -> 5.3.2 (*)
+|         |    +--- com.squareup.okhttp3:okhttp-tls:4.12.0 (*)
+|         |    +--- org.jetbrains.kotlinx:kotlinx-coroutines-core:1.10.2 (*)
+|         |    \--- org.jetbrains.kotlin:kotlin-stdlib:2.1.21 -> 2.2.21 (*)
+|         \--- org.jetbrains.kotlin:kotlin-stdlib:2.1.21 -> 2.2.21 (*)
-\--- rs.wordpress.api:android:trunk-21200d63735de310067d88c7dfb6080a2200f18e (*)
+\--- rs.wordpress.api:android:trunk-8d78ff73bc58961adb1059ea895eb946ff29bccb (*)

wpmobilebot · 2026-01-20T15:17:55Z

📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.

	App Name	WordPress
	Flavor	Jalapeno
	Build Type	Debug
	Version	pr22502-6fd1f52
	Commit	`6fd1f52`
	Direct Download	`wordpress-prototype-build-pr22502-6fd1f52.apk`

Note: Google Login is not supported on these builds.

wpmobilebot · 2026-01-20T15:21:04Z

📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.

	App Name	Jetpack
	Flavor	Jalapeno
	Build Type	Debug
	Version	pr22502-6fd1f52
	Commit	`6fd1f52`
	Direct Download	`jetpack-prototype-build-pr22502-6fd1f52.apk`

Note: Google Login is not supported on these builds.

adalpari · 2026-01-20T15:28:44Z

@claude

claude · 2026-01-20T15:29:06Z

Claude finished @adalpari's task in 1m 37s —— View job

Code Review Complete ✅

I've completed a comprehensive review of PR #22502. Overall, the implementation is solid with good test coverage. Below are my findings organized by category.

Todo List

Read and analyze all changed files
Review StatsRepository.kt (new file)
Review TodaysStatsViewModel.kt changes
Review StatsRepositoryTest.kt (new test file)
Review TodaysStatsViewModelTest.kt changes
Review dependency changes in libs.versions.toml
Provide comprehensive feedback

✅ Strengths

Excellent Test Coverage: Both StatsRepositoryTest.kt and TodaysStatsViewModelTest.kt have comprehensive test cases covering success, error, and edge cases
Clean Architecture: Good separation of concerns with Repository pattern and MVVM
Proper Error Handling: Well-structured sealed classes for result types
Thread Safety: Correct use of @Volatile for accessToken (StatsRepository.kt:44)
Documentation: Good KDoc comments explaining functionality

🔴 Critical Issues

1. Potential Data Loss in Long-to-Int Conversion

📍 TodaysStatsViewModel.kt:116-119

TodayStatsData(
    views = result.aggregates.views.toInt(),
    visitors = result.aggregates.visitors.toInt(),
    likes = result.aggregates.likes.toInt(),
    comments = result.aggregates.comments.toInt()
)

Issue: Converting Long to Int can cause overflow if values exceed Int.MAX_VALUE (2,147,483,647). For high-traffic sites, views could exceed this.

Recommendation: Either keep as Long throughout or use .coerceIn(0, Int.MAX_VALUE) to prevent silent overflow.

Fix this →

⚠️ Medium Priority Issues

2. Hardcoded Date Format Locale

📍 StatsRepository.kt:52

private val dateFormat = SimpleDateFormat("yyyy-MM-dd", Locale.ROOT)

Issue: While Locale.ROOT is correct for API communication, this is a class-level property. If SimpleDateFormat instances are reused across threads (unlikely here due to coroutines, but architecturally fragile), this could cause issues.

Recommendation: Consider moving to a thread-safe alternative or document thread-safety assumptions.

3. Calendar Offset Logic Could Be Clearer

📍 StatsRepository.kt:127

calendar.add(Calendar.DAY_OF_YEAR, 1 - offsetDays)

Issue: The formula 1 - offsetDays is confusing:

offsetDays=0 → adds 1 day (tomorrow)
offsetDays=1 → adds 0 days (today)

Recommendation: Add a comment explaining why this adds 1 day, or refactor for clarity:

// API expects endDate to be one day after the target date for hourly queries
calendar.add(Calendar.DAY_OF_YEAR, 1 - offsetDays)

4. Inconsistent Error Handling Pattern

📍 TodaysStatsViewModel.kt:103-107

} catch (e: Exception) {
    _uiState.value = TodaysStatsCardUiState.Error(
        message = e.message ?: resourceProvider.getString(R.string.stats_todays_stats_unknown_error),
        onRetry = { loadData(forced = true) }
    )
}

Issue: Catching Exception is too broad. If there's an unexpected OutOfMemoryError or other critical error, it shouldn't be handled as a retryable stats error.

Recommendation: Catch specific exceptions (IOException, HttpException, etc.) or at minimum catch RuntimeException instead of Exception.

5. Missing Index Constant

📍 StatsRepository.kt:23-28

private const val INDEX_VIEWS = 1
private const val INDEX_VISITORS = 2
private const val INDEX_LIKES = 3
private const val INDEX_COMMENTS = 5  // Missing INDEX_REBLOGS = 4

Issue: INDEX_REBLOGS = 4 is not defined but referenced in comments. While not used in code, this creates confusion.

Recommendation: Add private const val INDEX_REBLOGS = 4 for completeness and documentation purposes.

💡 Minor Improvements

6. Suppress Annotation Could Be More Specific

📍 TodaysStatsViewModel.kt:73

@Suppress("TooGenericExceptionCaught", "UnusedParameter")

Issue: UnusedParameter is suppressed for forced parameter which is indeed unused.

Recommendation: Either use the forced parameter for cache invalidation logic, or remove it and document why it's not needed.

7. Fallback Date Parsing Could Be Simplified

📍 TodaysStatsViewModel.kt:158-177

The nested try-catch for date parsing is comprehensive but complex. Consider extracting to a separate function for testability.

8. Test Constants Could Be More Descriptive

📍 StatsRepositoryTest.kt:394-405

private const val TEST_VIEWS = 500L
private const val TEST_VISITORS = 100L

Suggestion: Consider using more realistic test values or add comments explaining why these specific values were chosen.

9. Unused Return Value

📍 TodaysStatsViewModel.kt:179-181

private fun onCardClicked() {
    // Navigation will be handled by the parent
}

Issue: This is a placeholder. Consider adding a TODO or removing if not yet implemented.

🔍 Security & Performance

10. Access Token Storage ✅

The @Volatile annotation on accessToken is correct for thread visibility. The lazy initialization of wpComApiClient with null-check is appropriate.

11. Input Validation ✅

Good defensive programming with:

Null checks for accessToken
Safe list access with getOrNull()
Type checking with is operator
Default values (0L) for invalid data

📊 Test Quality

Excellent Coverage in Both Test Files:

✅ Success and error paths
✅ Edge cases (null, empty, invalid data)
✅ State transitions
✅ Refresh behavior
✅ Multiple offsetDays scenarios

Minor: Consider adding test for overflow scenario (Long to Int conversion mentioned above).

📦 Dependency Changes

`gradle/libs.versions.toml:105`

wordpress-rs = '1106-8dad0111fb97082cc2ab4280835d4e1e3167210a'

Note: As mentioned in your review comment, this points to a PR branch. ✅ Confirmed this will be updated to trunk before merge.

📝 Summary

Overall Assessment: Strong implementation with minor issues 🟢

The code demonstrates:

Good architectural patterns (Repository, MVVM, sealed classes)
Comprehensive test coverage
Proper error handling and logging
Clean, readable code

Recommended Actions Before Merge:

✅ Must Fix: Address Long-to-Int overflow issue (Menu Drawer Item refactor #1)
✅ Should Fix: Update wordpress-rs dependency to trunk (already planned)
💡 Consider: Improve exception handling specificity (Fix for bug #403 #4)
💡 Consider: Add clarity comment for calendar offset logic (WordPress.com Notifications in Android #3)

Great work on this implementation! The migration to wordpress-rs is clean and well-tested.

--- | Branch: feat/CMM-1142-stats-Create-Todays-card-rust

codecov · 2026-01-20T15:38:25Z

Codecov Report

❌ Patch coverage is 90.20979% with 14 lines in your changes missing coverage. Please review.
✅ Project coverage is 38.89%. Comparing base (5a02b7b) to head (6fd1f52).
⚠️ Report is 4 commits behind head on trunk.

Files with missing lines	Patch %	Lines
.../android/ui/newstats/todaysstat/StatsRepository.kt	87.50%	9 Missing and 4 partials ⚠️
...oid/ui/newstats/todaysstat/TodaysStatsViewModel.kt	97.14%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##            trunk   #22502      +/-   ##
==========================================
+ Coverage   38.84%   38.89%   +0.04%     
==========================================
  Files        2193     2194       +1     
  Lines      105921   106024     +103     
  Branches    14982    14995      +13     
==========================================
+ Hits        41148    41240      +92     
- Misses      61333    61341       +8     
- Partials     3440     3443       +3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

nbradbury

Looks good!

sonarqubecloud · 2026-01-21T08:46:34Z

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

adalpari added 19 commits January 16, 2026 16:44

Adding card and basic info

8fb79cb

Add horuly granularity

ae2806a

Some styling

656d93d

Following iOS distribution

8042b2d

Adding yesterday's data

7fb9d33

Gradiente and style

2fb7760

Line fixes

57600d9

detekt

b532c6e

Adding tests

122fbad

trailing line

f500411

Extractign strings

89afd04

Adding pull to refresh

69a4882

Using rust library

1b5c9c0

Fixing date period

0090c42

Updating version

8b0f0bc

Calling daily aggregates

4041ea7

Adding tests

a9e8d6e

detekt

c29f34b

adalpari requested a review from a team as a code owner January 20, 2026 14:45

adalpari requested review from nbradbury and removed request for a team January 20, 2026 14:45

adalpari added the [Type] Task label Jan 20, 2026

adalpari commented Jan 20, 2026

View reviewed changes

Rename and tests

fdbc47a

nbradbury self-assigned this Jan 20, 2026

adalpari added 2 commits January 20, 2026 16:44

Using Long instead of Int for stats

015fc0c

Other PR suggestions

abefb77

nbradbury approved these changes Jan 20, 2026

View reviewed changes

Using RS trunk version

6fd1f52

adalpari enabled auto-merge (squash) January 21, 2026 08:57

adalpari merged commit 35ff495 into trunk Jan 21, 2026
21 of 22 checks passed

adalpari deleted the feat/CMM-1142-stats-Create-Todays-card-rust branch January 21, 2026 09:17

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

CMM-1142 stats create todays card rust#22502

CMM-1142 stats create todays card rust#22502
adalpari merged 23 commits intotrunkfrom
feat/CMM-1142-stats-Create-Todays-card-rust

adalpari commented Jan 20, 2026 •

edited

Loading

Uh oh!

dangermattic commented Jan 20, 2026 •

edited

Loading

Uh oh!

adalpari Jan 20, 2026

Uh oh!

wpmobilebot commented Jan 20, 2026 •

edited

Loading

Uh oh!

wpmobilebot commented Jan 20, 2026 •

edited

Loading

Uh oh!

wpmobilebot commented Jan 20, 2026 •

edited

Loading

Uh oh!

adalpari commented Jan 20, 2026

Uh oh!

claude bot commented Jan 20, 2026 •

edited

Loading

Uh oh!

codecov bot commented Jan 20, 2026 •

edited

Loading

Uh oh!

nbradbury left a comment

Uh oh!

sonarqubecloud bot commented Jan 21, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

adalpari commented Jan 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Testing instructions

Uh oh!

dangermattic commented Jan 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

adalpari Jan 20, 2026

Choose a reason for hiding this comment

Uh oh!

wpmobilebot commented Jan 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Project dependencies changes

Uh oh!

wpmobilebot commented Jan 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wpmobilebot commented Jan 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

adalpari commented Jan 20, 2026

Uh oh!

claude bot commented Jan 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Review Complete ✅

Todo List

✅ Strengths

🔴 Critical Issues

1. Potential Data Loss in Long-to-Int Conversion

⚠️ Medium Priority Issues

2. Hardcoded Date Format Locale

3. Calendar Offset Logic Could Be Clearer

4. Inconsistent Error Handling Pattern

5. Missing Index Constant

💡 Minor Improvements

6. Suppress Annotation Could Be More Specific

7. Fallback Date Parsing Could Be Simplified

8. Test Constants Could Be More Descriptive

9. Unused Return Value

🔍 Security & Performance

10. Access Token Storage ✅

11. Input Validation ✅

📊 Test Quality

Excellent Coverage in Both Test Files:

📦 Dependency Changes

gradle/libs.versions.toml:105

📝 Summary

Uh oh!

codecov bot commented Jan 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

nbradbury left a comment

Choose a reason for hiding this comment

Uh oh!

sonarqubecloud bot commented Jan 21, 2026

Quality Gate passed

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

adalpari commented Jan 20, 2026 •

edited

Loading

dangermattic commented Jan 20, 2026 •

edited

Loading

wpmobilebot commented Jan 20, 2026 •

edited

Loading

wpmobilebot commented Jan 20, 2026 •

edited

Loading

wpmobilebot commented Jan 20, 2026 •

edited

Loading

claude bot commented Jan 20, 2026 •

edited

Loading

`gradle/libs.versions.toml:105`

codecov bot commented Jan 20, 2026 •

edited

Loading