-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Material 3: Voice to content #21427
Material 3: Voice to content #21427
Conversation
Generated by 🚫 Danger |
Quality Gate passedIssues Measures |
📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
|
📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## trunk #21427 +/- ##
=======================================
Coverage 39.30% 39.30%
=======================================
Files 2121 2121
Lines 98326 98326
Branches 15233 15233
=======================================
Hits 38649 38649
Misses 56238 56238
Partials 3439 3439 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look sound, testing succeeded.
I noted the UI is unexpectedly obscured from content overflow scrolling. Also, a11y needs improvement, as there are little-to-no labels for the interactive elements—e.g., buttons, live regions. That said, these issues are also present on the trunk
branch.
Start | In-Progress |
---|---|
Oh, interesting. It looks like that happens on smaller screens. Which device are you testing with? |
A Samsung Galaxy S20 5G FE. I consider it a fairly large device screen. |
Yes, that is a large screen. I'm not sure why the overlap is happening, then, but since it happens in |
This PR converts the "Voice to content" feature to Material3. To test:
voice_to_content
in Debug Settings > Remote Featuresaudio.mp4