Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Material 3: Voice to content #21427

Merged
merged 3 commits into from
Nov 6, 2024
Merged

Material 3: Voice to content #21427

merged 3 commits into from
Nov 6, 2024

Conversation

nbradbury
Copy link
Contributor

@nbradbury nbradbury commented Nov 6, 2024

This PR converts the "Voice to content" feature to Material3. To test:

  • Enable voice_to_content in Debug Settings > Remote Features
  • Tap the FAB on My Site
  • Select "Post from audio"
  • Verify it looks as expected
audio.mp4

@dangermattic
Copy link
Collaborator

dangermattic commented Nov 6, 2024

1 Warning
⚠️ PR is not assigned to a milestone.

Generated by 🚫 Danger

Copy link

sonarqubecloud bot commented Nov 6, 2024

@wpmobilebot
Copy link
Contributor

WordPress📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress WordPress
FlavorJalapeno
Build TypeDebug
Versionpr21427-96cf3ab
Commit96cf3ab
Direct Downloadwordpress-prototype-build-pr21427-96cf3ab.apk
Note: Google Login is not supported on these builds.

@wpmobilebot
Copy link
Contributor

Jetpack📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack Jetpack
FlavorJalapeno
Build TypeDebug
Versionpr21427-96cf3ab
Commit96cf3ab
Direct Downloadjetpack-prototype-build-pr21427-96cf3ab.apk
Note: Google Login is not supported on these builds.

Copy link

codecov bot commented Nov 6, 2024

Codecov Report

Attention: Patch coverage is 0% with 24 lines in your changes missing coverage. Please review.

Project coverage is 39.30%. Comparing base (236ee0d) to head (96cf3ab).
Report is 9 commits behind head on trunk.

Files with missing lines Patch % Lines
.../android/ui/voicetocontent/VoiceToContentScreen.kt 0.00% 19 Missing ⚠️
...rdpress/android/ui/voicetocontent/MicToStopIcon.kt 0.00% 4 Missing ⚠️
...ss/android/ui/voicetocontent/WaveformVisualizer.kt 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            trunk   #21427   +/-   ##
=======================================
  Coverage   39.30%   39.30%           
=======================================
  Files        2121     2121           
  Lines       98326    98326           
  Branches    15233    15233           
=======================================
  Hits        38649    38649           
  Misses      56238    56238           
  Partials     3439     3439           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nbradbury nbradbury requested a review from dcalhoun November 6, 2024 15:38
@nbradbury nbradbury marked this pull request as ready for review November 6, 2024 15:38
@nbradbury nbradbury changed the title Issue/voicetocontent m3 Material 3: Voice to content Nov 6, 2024
Copy link
Member

@dcalhoun dcalhoun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look sound, testing succeeded.

I noted the UI is unexpectedly obscured from content overflow scrolling. Also, a11y needs improvement, as there are little-to-no labels for the interactive elements—e.g., buttons, live regions. That said, these issues are also present on the trunk branch.

Start In-Progress
Screenshot_20241106_150007_Jetpack Pre-Alpha Screenshot_20241106_150023_Jetpack Pre-Alpha

@nbradbury
Copy link
Contributor Author

I noted the UI is unexpectedly obscured from content overflow scrolling.

Oh, interesting. It looks like that happens on smaller screens. Which device are you testing with?

@dcalhoun
Copy link
Member

dcalhoun commented Nov 6, 2024

I noted the UI is unexpectedly obscured from content overflow scrolling.

Oh, interesting. It looks like that happens on smaller screens. Which device are you testing with?

A Samsung Galaxy S20 5G FE. I consider it a fairly large device screen.

@nbradbury
Copy link
Contributor Author

A Samsung Galaxy S20 5G FE. I consider it a fairly large device screen.

Yes, that is a large screen. I'm not sure why the overlap is happening, then, but since it happens in trunk I'll file a separate issue for it. Thanks!

@nbradbury nbradbury merged commit 3b3b4f0 into trunk Nov 6, 2024
28 checks passed
@nbradbury nbradbury deleted the issue/voicetocontent-m3 branch November 6, 2024 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants