Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a rare crash on featured image confirmation dialog #20836

Merged
merged 3 commits into from
May 18, 2024
Merged

Fix a rare crash on featured image confirmation dialog #20836

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0747bbd
Fix the crash on featured image confirmation dialog
irfano May 16, 2024
62250f0
Update RELEASE-NOTES.txt
irfano May 16, 2024
b5bd863
Merge branch 'trunk' into issue/20535-fix-crash-on-featured-image-dialog
irfano May 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions RELEASE-NOTES.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
-----
* [*] Fixed a rare crash on Posts List screen [https://github.com/wordpress-mobile/WordPress-Android/pull/20813]
* [*] Fixed a rare crash on the Login screen [https://github.com/wordpress-mobile/WordPress-Android/pull/20821]
* [*] Fixed a rare crash on the featured image confirmation dialog [https://github.com/wordpress-mobile/WordPress-Android/pull/20836]
* [*] Fixed an ANR issue on the Post List screen [https://github.com/wordpress-mobile/WordPress-Android/pull/20833]

24.9
Expand Down
4 changes: 4 additions & 0 deletions .../editor/src/main/java/org/wordpress/android/editor/gutenberg/GutenbergEditorFragment.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -901,6 +901,10 @@ public void onClick(DialogInterface dialog, int id) {

@UiThread
public void showFeaturedImageConfirmationDialog(final int mediaId) {
if (isStateSaved()) {
return;
}

GutenbergDialogFragment dialog = new GutenbergDialogFragment();
dialog.initialize(
TAG_REPLACE_FEATURED_DIALOG,
Expand Down
Loading