Fix a rare crash on Post List screen

[irfano]

This fixes some parts of #20535.

The crash message is Can not perform this action after onSaveInstanceState. It indicates that supportFragmentManager...commit() function cannot be executed after onSaveInstanceState is called. Based on the logs, onCreateOptionsMenu() is invoked after the fragment is stopped. I moved initSearchFragment() function from onCreateOptionsMenu() to onCreate(). Apart from this issue, I believe onCreate is a more suitable location for it.

To reproduce this crash:

1. Pull trunk
2. Add a delay to the initSearchFragment() function in the PostsListActivity.onCreateOptionsMenu().

3. Open post list from Menu.
4. Immediately send the app to the background after opening the post list.

---

To Test:

Test the reproduction steps above.

---

Regression Notes

1. Potential unintended areas of impact

   • None

2. What I did to test those areas of impact (or what existing automated tests I relied on)

   • N/A

3. What automated tests I added (or what prevented me from doing so)

   • This doesn't introduce any behavior change.

---

PR Submission Checklist:

• I have completed the Regression Notes.
• I have considered adding accessibility improvements for my changes.
• I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

---

Testing Checklist (strike-out the not-applying and unnecessary ones):

• WordPress.com sites and self-hosted Jetpack sites.
• Portrait and landscape orientations.
• Light and dark modes.
• Fonts: Larger, smaller and bold text.
• High contrast.
• Talkback.
• Languages with large words or with letters/accents not frequently used in English.
• Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
• Large and small screen sizes. (Tablet and smaller phones)
• Multi-tasking: Split screen and Pop-up view. (Android 10 or higher)

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

[wpmobilebot]

📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.

	App Name	WordPress
	Flavor	Jalapeno
	Build Type	Debug
	Version	pr20813-2500a00
	Commit	2500a00
	Direct Download	wordpress-prototype-build-pr20813-2500a00.apk

Note: Google Login is not supported on these builds.

[wpmobilebot]

📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.

	App Name	Jetpack
	Flavor	Jalapeno
	Build Type	Debug
	Version	pr20813-2500a00
	Commit	2500a00
	Direct Download	jetpack-prototype-build-pr20813-2500a00.apk

Note: Google Login is not supported on these builds.

[aditi-bhatia]

This is the crash that I see but it seems related to the original one:

Changes make sense, LGTM

[sentry-io]

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

• ‼️ ApplicationNotResponding: ANR org.wordpress.android.fluxc.persistence.SiteSql... View Issue

_{Did you find this useful? React with a 👍 or 👎}