Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the alignment issue in RTL #20804

Merged
merged 5 commits into from
May 13, 2024
Merged

Fix the alignment issue in RTL #20804

merged 5 commits into from
May 13, 2024

Conversation

jarvislin
Copy link
Contributor

@jarvislin jarvislin commented May 13, 2024

Fixes #20803

The RTL in the screen of Site Picker was not handled during the development so this PR fixes the alignment issue in RTL mode.

Before After
Screenshot_٢٠٢٤٠٥١٣-١١١٠١٥

To Test:

  1. Sign in JP app
  2. Go to Me tab → App language
  3. Set language as Arabic or any other RTL language
  4. Go to My Site tab
  5. Click the v arrow icon at the top of screen to open Site Picker
  6. The UI in RTL should be correct.
  7. Done, thank you!

Regression Notes

  1. Potential unintended areas of impact

    • site switcher
  2. What I did to test those areas of impact (or what existing automated tests I relied on)

    • manual
  3. What automated tests I added (or what prevented me from doing so)

    • n/a

PR Submission Checklist:

  • I have completed the Regression Notes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing Checklist (strike-out the not-applying and unnecessary ones):

  • WordPress.com sites and self-hosted Jetpack sites.
  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • Talkback.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • Large and small screen sizes. (Tablet and smaller phones)
  • Multi-tasking: Split screen and Pop-up view. (Android 10 or higher)

@jarvislin jarvislin added this to the 24.9 milestone May 13, 2024
@jarvislin jarvislin requested a review from antonis May 13, 2024 08:30
@jarvislin jarvislin marked this pull request as ready for review May 13, 2024 08:30
@jarvislin jarvislin modified the milestones: 24.9, 25.0 May 13, 2024
@@ -1,5 +1,9 @@
*** PLEASE FOLLOW THIS FORMAT: [<priority indicator, more stars = higher priority>] <description> [<PR URL>]

25.0
-----
* [*] Site picker: Fixed the UI alignment issue in RTL [https://github.com/wordpress-mobile/WordPress-Android/pull/20804]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Due to timezones I think we have a few more hours till the release 24.9 is cut. Wdyt of targeting 24.9 and updating the release note?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good!

Copy link
Contributor

@antonis antonis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the quick fix @jarvislin 🙇
The code changes LGTM and the app behaves as expected in RTL 🎉

screenshot

Screenshot_20240513_120128

@wpmobilebot
Copy link
Contributor

wpmobilebot commented May 13, 2024

Jetpack📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack Jetpack
FlavorJalapeno
Build TypeDebug
Versionpr20804-bb30192
Commitbb30192
Direct Downloadjetpack-prototype-build-pr20804-bb30192.apk
Note: Google Login is not supported on these builds.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented May 13, 2024

WordPress📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress WordPress
FlavorJalapeno
Build TypeDebug
Versionpr20804-bb30192
Commitbb30192
Direct Downloadwordpress-prototype-build-pr20804-bb30192.apk
Note: Google Login is not supported on these builds.

@jarvislin jarvislin modified the milestones: 25.0, 24.9 May 13, 2024
@dangermattic
Copy link
Collaborator

1 Warning
⚠️ This PR is assigned to the milestone 24.9. The due date for this milestone has already passed.
Please assign it to a milestone with a later deadline or check whether the release for this milestone has already been finished.

Generated by 🚫 Danger

@jarvislin jarvislin enabled auto-merge May 13, 2024 09:30
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@jarvislin jarvislin merged commit 09194c1 into trunk May 13, 2024
18 of 22 checks passed
@jarvislin jarvislin deleted the fix/20803-rtl-alignment-issue branch May 13, 2024 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Site selection screen]: Site name and url overflows in RTL orientation
4 participants