-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove social subscribers #20763
Remove social subscribers #20763
Conversation
Generated by 🚫 Danger |
📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
|
📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## trunk #20763 +/- ##
==========================================
- Coverage 40.69% 40.65% -0.05%
==========================================
Files 1491 1490 -1
Lines 68677 68579 -98
Branches 11357 11332 -25
==========================================
- Hits 27949 27878 -71
+ Misses 38191 38183 -8
+ Partials 2537 2518 -19 ☔ View full report in Codecov by Sentry. |
…-Android into issue/20714-remove-social-subcribers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm, works as expected 👍 I went ahead and merged in trunk since there was a conflict. Just curious, when would be considered a good time to remove InsightType.FOLLOWER_TOTALS
from FluxC?
Quality Gate passedIssues Measures |
Thanks for resolving the conflict.
I've made a note of it for myself. I will remove it after the project by checking if it affects old versions. |
Sounds good, thanks! |
Fixes #20714
This removes social subribers from the detail screen of the Total Followers card and additionally, changes the endpoint for the "Total Followers" card from
/sites/$site/stats/summary/
→stats/subscribers
.Additionally, this PR removes
FollowerTotalsUseCase
, which was already unused. This card was being used only on the WordPress app but then we removed stats from WP, now it's fine to remove the usecase as well. I haven't removedInsightType.FOLLOWER_TOTALS
from FLuxC for now because it may cause crashes on a case when upgraded from a very old version since selected insight cards are stored in the db.To Test:
Regression Notes
Potential unintended areas of impact
What I did to test those areas of impact (or what existing automated tests I relied on)
What automated tests I added (or what prevented me from doing so)
FollowerTypesUseCaseTest
andFollowerTotalsUseCaseTest
PR Submission Checklist:
RELEASE-NOTES.txt
if necessary.Testing Checklist (strike-out the not-applying and unnecessary ones):
WordPress.com sites and self-hosted Jetpack sites.Portrait and landscape orientations.Light and dark modes.Fonts: Larger, smaller and bold text.High contrast.Talkback.Languages with large words or with letters/accents not frequently used in English.Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)Large and small screen sizes. (Tablet and smaller phones)Multi-tasking: Split screen and Pop-up view. (Android 10 or higher)