Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change "∞" symbol with "100%" on stats #20564

Merged
merged 4 commits into from
Apr 2, 2024

Conversation

irfano
Copy link
Member

@irfano irfano commented Mar 31, 2024

Fixes #17314

This changes "∞" symbol with "100%" on stats. The issue description states removing "∞" symbol but this PR changes it to "%100" and matches this behavior with the web.

before after

To Test:

  1. Log in.
  2. Open "My Site → Stats"
  3. Select the INSIGHTS tab.
  4. Select a date that has 0 views for the previous date on Views & Visitors card.
  5. Verify that the data shows "%100" instead of "∞".
  6. Repeat the same test for total cards.
  7. Repeat the same test for the Overview card on granular tabs.

Regression Notes

  1. Potential unintended areas of impact

    • None
  2. What I did to test those areas of impact (or what existing automated tests I relied on)

    • N/A
  3. What automated tests I added (or what prevented me from doing so)

    • Updated StatsUtilsTest.

PR Submission Checklist:

  • I have completed the Regression Notes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing Checklist (strike-out the not-applying and unnecessary ones):

  • WordPress.com sites and self-hosted Jetpack sites.
  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • Talkback.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • Large and small screen sizes. (Tablet and smaller phones)
  • Multi-tasking: Split screen and Pop-up view. (Android 10 or higher)

@irfano irfano added this to the 24.6 milestone Mar 31, 2024
@irfano irfano requested a review from ravishanker March 31, 2024 23:21
@irfano irfano modified the milestones: 24.6, 24.7 Mar 31, 2024
@irfano irfano force-pushed the issue/17314-fix-∞-symbol-on-stats branch from 15b3d03 to db04745 Compare March 31, 2024 23:27
@irfano irfano requested review from notandyvee and aditi-bhatia and removed request for ravishanker March 31, 2024 23:28
@wpmobilebot
Copy link
Contributor

wpmobilebot commented Mar 31, 2024

WordPress📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress WordPress
FlavorJalapeno
Build TypeDebug
Versionpr20564-e3d6cb8
Commite3d6cb8
Direct Downloadwordpress-prototype-build-pr20564-e3d6cb8.apk
Note: Google Login is not supported on these builds.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Mar 31, 2024

Jetpack📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack Jetpack
FlavorJalapeno
Build TypeDebug
Versionpr20564-e3d6cb8
Commite3d6cb8
Direct Downloadjetpack-prototype-build-pr20564-e3d6cb8.apk
Note: Google Login is not supported on these builds.

Copy link

codecov bot commented Mar 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 40.31%. Comparing base (c188122) to head (db04745).
Report is 12 commits behind head on trunk.

❗ Current head db04745 differs from pull request most recent head e3d6cb8. Consider uploading reports for the commit e3d6cb8 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##            trunk   #20564   +/-   ##
=======================================
  Coverage   40.31%   40.31%           
=======================================
  Files        1472     1472           
  Lines       67836    67836           
  Branches    11218    11218           
=======================================
  Hits        27351    27351           
  Misses      38019    38019           
  Partials     2466     2466           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@aditi-bhatia aditi-bhatia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change definitely makes more sense 👍 LGTM

@aditi-bhatia
Copy link
Contributor

aditi-bhatia commented Apr 1, 2024

@irfano Just wanted to double check, it looks like the 24.6 code freeze is today. Do you know if it's already begun / if this PR will be going into 24.6 or 24.7? I see the update to Release Notes mentions 24.7 and want to make sure the version is correct if merged today.

Put it into 24.6 since it is delayed
@ravishanker ravishanker modified the milestones: 24.7, 24.6 Apr 2, 2024
@dangermattic
Copy link
Collaborator

1 Warning
⚠️ This PR is assigned to the milestone 24.6. The due date for this milestone has already passed.
Please assign it to a milestone with a later deadline or check whether the release for this milestone has already been finished.

Generated by 🚫 Danger

@ravishanker ravishanker enabled auto-merge April 2, 2024 02:08
Copy link

sonarqubecloud bot commented Apr 2, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@ravishanker ravishanker merged commit 4384ad9 into trunk Apr 2, 2024
18 of 22 checks passed
@ravishanker ravishanker deleted the issue/17314-fix-∞-symbol-on-stats branch April 2, 2024 02:29
@irfano
Copy link
Member Author

irfano commented Apr 2, 2024

@irfano Just wanted to double check, it looks like the 24.6 code freeze is today. Do you know if it's already begun / if this PR will be going into 24.6 or 24.7? I see the update to Release Notes mentions 24.7 and want to make sure the version is correct if merged today.

I initially thought we couldn't merge this before the 24.6 code freeze. However, since the code freeze didn't happen yesterday, Ravi already updated the version in the release notes and merged it into 24.6. Thank you both!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"(∞)" shouldn't be used for infinite percentages in stats screens
5 participants