-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change "∞" symbol with "100%" on stats #20564
The head ref may contain hidden characters: "issue/17314-fix-\u221E-symbol-on-stats"
Conversation
15b3d03
to
db04745
Compare
📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
|
📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## trunk #20564 +/- ##
=======================================
Coverage 40.31% 40.31%
=======================================
Files 1472 1472
Lines 67836 67836
Branches 11218 11218
=======================================
Hits 27351 27351
Misses 38019 38019
Partials 2466 2466 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change definitely makes more sense 👍 LGTM
@irfano Just wanted to double check, it looks like the 24.6 code freeze is today. Do you know if it's already begun / if this PR will be going into 24.6 or 24.7? I see the update to |
Put it into 24.6 since it is delayed
Quality Gate passedIssues Measures |
I initially thought we couldn't merge this before the 24.6 code freeze. However, since the code freeze didn't happen yesterday, Ravi already updated the version in the release notes and merged it into |
Fixes #17314
This changes "∞" symbol with "100%" on stats. The issue description states removing "∞" symbol but this PR changes it to "%100" and matches this behavior with the web.
To Test:
Regression Notes
Potential unintended areas of impact
What I did to test those areas of impact (or what existing automated tests I relied on)
What automated tests I added (or what prevented me from doing so)
StatsUtilsTest
.PR Submission Checklist:
RELEASE-NOTES.txt
if necessary.Testing Checklist (strike-out the not-applying and unnecessary ones):
WordPress.com sites and self-hosted Jetpack sites.Portrait and landscape orientations.Light and dark modes.Fonts: Larger, smaller and bold text.High contrast.Talkback.Languages with large words or with letters/accents not frequently used in English.Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)Large and small screen sizes. (Tablet and smaller phones)Multi-tasking: Split screen and Pop-up view. (Android 10 or higher)